This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Symbol changes #1, LLD
ClosedPublic

Authored by ncw on Jan 15 2018, 9:07 AM.

Details

Summary

First chunk split out of D41955.

Must be committed simultaneously with LLD change, D42075.

Changes:

  • Update for DEBUG_FUNCTION_NAME disappearing
  • Simplify generation of "names" section by simply iterating over the DefinedFunctions array.
  • Apparently, this even fixes some bugs, judging by the test changes required - some tests are asserting that functions are named multiple times, other tests are asserting that the "names" section contains the function's alias rather than its original name...
  • Rolled in some tiny formatting changes...

Diff Detail

Repository
rLLD LLVM Linker

Event Timeline

ncw created this revision.Jan 15 2018, 9:07 AM
ncw updated this revision to Diff 130124.Jan 17 2018, 4:28 AM

Updated:

  • Revert change to remove imports from NAME section; now names are written out for imported functions as before

Landed two smaller parts as: rLLD322726 and rLLD322727

wasm/Writer.cpp
471–472

Maybe NumNames?

sbc100 accepted this revision.Jan 17 2018, 10:53 AM
This revision is now accepted and ready to land.Jan 17 2018, 10:53 AM

One more split off change: rLLD322731

Another change split off: D42193

This revision was automatically updated to reflect the committed changes.