This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Remove DEBUG_FUNCTION_NAME after llvm change
ClosedPublic

Authored by sbc100 on Jan 17 2018, 11:33 AM.

Diff Detail

Repository
rLLD LLVM Linker

Event Timeline

sbc100 created this revision.Jan 17 2018, 11:33 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 17 2018, 11:37 AM
This revision was automatically updated to reflect the committed changes.
ncw added a comment.Jan 17 2018, 2:25 PM

Thanks for splitting. It would be an extremely long chain of patches if I submitted them in chunks this small - I hope the chunks I'm using are roughly the right size for sending to you to (I could go bigger or smaller).

As a rule I always prefer smaller focused changes, but at the same time it can be overwhelming to get so many changes to review at the same time.

I would say that especially for things like typos its nice to separate them since reviewing them is so trivial, and it leaves the real meaty changes with less noise in them.