This is an archive of the discontinued LLVM Phabricator instance.

Differential D42011

[DWARFv5] Enable MD5 checksums
ClosedPublic

Authored by probinson on Jan 12 2018, 2:12 PM.

Details

Reviewers
dblaikie
aprantl
Commits
rG212f3b91ee17: [DWARFv5] Have -gdwarf-5 generate MD5 checksums
rC322413: [DWARFv5] Have -gdwarf-5 generate MD5 checksums
rL322413: [DWARFv5] Have -gdwarf-5 generate MD5 checksums
Summary

Under -gdwarf-5 generate MD5 checksums of source files to emit to the DWARF v5 line table.

This consumes 16 bytes per source file in the line table, but allows a debugger to verify that
the source file hasn't changed since build time, which Clang has never allowed before.

Diff Detail

Repository
rC Clang

Event Timeline

probinson created this revision.Jan 12 2018, 2:12 PM
Herald added subscribers: cfe-commits, JDevlieghere. · View Herald TranscriptJan 12 2018, 2:12 PM
aprantl accepted this revision.Jan 12 2018, 2:15 PM
This revision is now accepted and ready to land.Jan 12 2018, 2:15 PM
Closed by commit rL322413: [DWARFv5] Have -gdwarf-5 generate MD5 checksums (authored by probinson). · Explain WhyJan 12 2018, 2:22 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptJan 12 2018, 2:22 PM
Closed by commit rC322413: [DWARFv5] Have -gdwarf-5 generate MD5 checksums (authored by probinson). · Explain WhyJan 12 2018, 2:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
CodeGen/
3 lines
test/
CodeGen/
1 line

Diff 129708

lib/CodeGen/CGDebugInfo.cpp

Show First 20 Lines • Show All 359 Lines • ▼ Show 20 LinesStringRef CGDebugInfo::getClassName(const RecordDecl *RD) {
return StringRef(); return StringRef();
} }
llvm::DIFile::ChecksumKind llvm::DIFile::ChecksumKind
CGDebugInfo::computeChecksum(FileID FID, SmallString<32> &Checksum) const { CGDebugInfo::computeChecksum(FileID FID, SmallString<32> &Checksum) const {
Checksum.clear(); Checksum.clear();
if (!CGM.getCodeGenOpts().EmitCodeView) if (!CGM.getCodeGenOpts().EmitCodeView &&
CGM.getCodeGenOpts().DwarfVersion < 5)
return llvm::DIFile::CSK_None; return llvm::DIFile::CSK_None;
SourceManager &SM = CGM.getContext().getSourceManager(); SourceManager &SM = CGM.getContext().getSourceManager();
bool Invalid; bool Invalid;
llvm::MemoryBuffer *MemBuffer = SM.getBuffer(FID, &Invalid); llvm::MemoryBuffer *MemBuffer = SM.getBuffer(FID, &Invalid);
if (Invalid) if (Invalid)
return llvm::DIFile::CSK_None; return llvm::DIFile::CSK_None;
▲ Show 20 Lines • Show All 3,795 Lines • Show Last 20 Lines

test/CodeGen/debug-info-file-checksum.c

// RUN: %clang -emit-llvm -S -g -gcodeview -x c %S/Inputs/debug-info-file-checksum.c -o - | FileCheck %s // RUN: %clang -emit-llvm -S -g -gcodeview -x c %S/Inputs/debug-info-file-checksum.c -o - | FileCheck %s
// RUN: %clang -emit-llvm -S -gdwarf-5 -x c %S/Inputs/debug-info-file-checksum.c -o - | FileCheck %s
// Check that "checksum" is created correctly for the compiled file. // Check that "checksum" is created correctly for the compiled file.
// CHECK: !DIFile(filename:{{.*}}, directory:{{.*}}, checksumkind: CSK_MD5, checksum: "a3b7d27af071accdeccaa933fc603608") // CHECK: !DIFile(filename:{{.*}}, directory:{{.*}}, checksumkind: CSK_MD5, checksum: "a3b7d27af071accdeccaa933fc603608")