This is an archive of the discontinued LLVM Phabricator instance.

[X86] Fix missing predicates HasAVX512 Predicates in avx512_sqrt_scalar.
ClosedPublic

Authored by courbet on Jan 12 2018, 2:39 AM.

Details

Summary

For example, VSQRTSDZr and VSQRTSSZr were missing the predicate.
Also fix braces indentation and braces for consistency.

Diff Detail

Repository
rL LLVM

Event Timeline

courbet created this revision.Jan 12 2018, 2:39 AM
courbet updated this revision to Diff 129599.Jan 12 2018, 3:59 AM

Fix avx512_sqrt_scalar.

courbet retitled this revision from [X86] Fix missing braces in avx512_fp_broadcast_sd and avx512_fp_broadcast_ss. to [X86] Fix missing predicates HasAVX512 Predicates in avx512_sqrt_scalar..Jan 12 2018, 4:00 AM
courbet edited the summary of this revision. (Show Details)
courbet added a subscriber: llvm-commits.

I'm not sure there's a functional change here. The instructions that are being modified don't have patterns defined.

Yes, there are not functional changes for the current TableGen backends. I'm working on a new backend though, and these two instructions are inconsistent with all the other, which define predicates on the instructions themselves and not just the patterns.

RKSimon accepted this revision.Jan 15 2018, 3:51 AM

OK, LGTM

This revision is now accepted and ready to land.Jan 15 2018, 3:51 AM
This revision was automatically updated to reflect the committed changes.