This is an archive of the discontinued LLVM Phabricator instance.

Add tests for llvm-bcanalyzer stream types
ClosedPublic

Authored by modocache on Jan 11 2018, 9:34 PM.

Diff Detail

Event Timeline

modocache created this revision.Jan 11 2018, 9:34 PM
aprantl added inline comments.Jan 12 2018, 8:42 AM
test/PCH/include-stream-type.cpp
8

You may need to pass an explicit -fmodule-format=raw for this to work on macOS. Did you test there?

modocache added inline comments.Jan 12 2018, 9:03 AM
test/PCH/include-stream-type.cpp
8

Yup, I tested this on my macOS host machine and it seems to pass. Should add that option anyway, just in case?

aprantl accepted this revision.Jan 12 2018, 9:09 AM
aprantl added inline comments.
test/PCH/include-stream-type.cpp
8

Let's add it, just to be explicit and document the intent here.

This revision is now accepted and ready to land.Jan 12 2018, 9:09 AM

Added -fmodule-format=raw.

modocache marked 3 inline comments as done.
This revision was automatically updated to reflect the committed changes.