This is an archive of the discontinued LLVM Phabricator instance.

Differential D41980

Add tests for llvm-bcanalyzer stream types
ClosedPublic

Authored by modocache on Jan 11 2018, 9:34 PM.

Details

Reviewers
pcc
aprantl
mehdi_amini
george.karpenkov
Commits
rG2a58ca7dfe11: Add tests for llvm-bcanalyzer stream types
rL330530: Add tests for llvm-bcanalyzer stream types
rC330530: Add tests for llvm-bcanalyzer stream types
Summary

Add tests for the improved stream type detection added to
llvm-bcanalyzer in https://reviews.llvm.org/D41979.

Test Plan: check-clang

Diff Detail

Event Timeline

modocache created this revision.Jan 11 2018, 9:34 PM
Herald added a subscriber: a.sidorin. · View Herald TranscriptJan 11 2018, 9:34 PM
aprantl added inline comments.Jan 12 2018, 8:42 AM
test/PCH/include-stream-type.cpp
8

You may need to pass an explicit -fmodule-format=raw for this to work on macOS. Did you test there?

modocache added inline comments.Jan 12 2018, 9:03 AM
test/PCH/include-stream-type.cpp
8

Yup, I tested this on my macOS host machine and it seems to pass. Should add that option anyway, just in case?

aprantl accepted this revision.Jan 12 2018, 9:09 AM
aprantl added inline comments.
test/PCH/include-stream-type.cpp
8

Let's add it, just to be explicit and document the intent here.

This revision is now accepted and ready to land.Jan 12 2018, 9:09 AM
modocache updated this revision to Diff 143458.Apr 21 2018, 10:11 AM

Added -fmodule-format=raw.

Herald added a reviewer: george.karpenkov. · View Herald TranscriptApr 21 2018, 10:11 AM
modocache added a parent revision: D41979: [bcanalyzer] Recognize more stream types.Apr 21 2018, 10:12 AM
modocache marked 3 inline comments as done.
Closed by commit rC330530: Add tests for llvm-bcanalyzer stream types (authored by modocache). · Explain WhyApr 21 2018, 5:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
test/
Misc/
3 lines
PCH/
10 lines

Diff 143458

test/Misc/serialized-diags-bcanalyzer.c

  • This file was added.
// RUN: %clang -Wall -fsyntax-only %s --serialize-diagnostics %t.diag > /dev/null 2>&1
// RUN: llvm-bcanalyzer -dump %t.diag | FileCheck %s
// CHECK: Stream type: Clang Serialized Diagnostics

test/PCH/include-stream-type.cpp

  • This file was added.
// Test that llvm-bcanalyzer recognizes the stream type of a PCH file.
// RUN: mkdir -p %t-dir
// Copying files allow for read-only checkouts to run this test.
// RUN: cp %S/Inputs/pragma-once2-pch.h %t-dir
// RUN: cp %S/Inputs/pragma-once2.h %t-dir
// RUN: %clang_cc1 -x c++-header -emit-pch -fmodule-format=raw -o %t %t-dir/pragma-once2-pch.h
// RUN: llvm-bcanalyzer -dump %t | FileCheck %s
aprantlUnsubmitted
Done
ReplyInline Actions

You may need to pass an explicit -fmodule-format=raw for this to work on macOS. Did you test there?

aprantl: You may need to pass an explicit -fmodule-format=raw for this to work on macOS. Did you test…
modocacheAuthorUnsubmitted
Done
ReplyInline Actions

Yup, I tested this on my macOS host machine and it seems to pass. Should add that option anyway, just in case?

modocache: Yup, I tested this on my macOS host machine and it seems to pass. Should add that option anyway…
aprantlUnsubmitted
Done
ReplyInline Actions

Let's add it, just to be explicit and document the intent here.

aprantl: Let's add it, just to be explicit and document the intent here.
//
// CHECK: Stream type: Clang Serialized AST