Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Paths
Table of Contents
t
Hide Panel
f
Keyboard Reference
?
Differential
D41959
[WebAssemlby] Don't write COMDAT symbols as global imports
Closed
Public
Actions
Authored by
sbc100
on Jan 11 2018, 11:41 AM.
Edit Revision
Update Diff
Download Raw Diff
Edit Related Revisions...
Edit Parent Revisions
Edit Child Revisions
Edit Related Objects...
Edit Commits
Subscribe
Mute Notifications
Award Token
Flag For Later
Tags
None
Subscribers
aheejin
dschuff
jfb
jgravelle-google
llvm-commits
sunfish
Details
Reviewers
nwilson
dschuff
Commits
rGd423f0d29057: [WebAssemlby] MC: Don't write COMDAT symbols as global imports
rL322309: [WebAssemlby] MC: Don't write COMDAT symbols as global imports
Summary
This was causing undefined references at link time in lld.
Diff Detail
Repository
rL LLVM
Event Timeline
sbc100
created this revision.
Jan 11 2018, 11:41 AM
Harbormaster
completed remote builds in
B13727: Diff 129493
.
Jan 11 2018, 11:41 AM
Herald
added subscribers:
sunfish
,
aheejin
,
jgravelle-google
and
2 others
.
·
View Herald Transcript
Jan 11 2018, 11:41 AM
sbc100
updated this revision to
Diff 129494
.
Jan 11 2018, 11:42 AM
Comment Actions
less
Harbormaster
completed remote builds in
B13728: Diff 129494
.
Jan 11 2018, 11:42 AM
sbc100
updated this revision to
Diff 129497
.
Jan 11 2018, 12:06 PM
Comment Actions
fix issue with importing comdat symbols.
Harbormaster
completed remote builds in
B13729: Diff 129497
.
Jan 11 2018, 12:06 PM
sbc100
retitled this revision from
[WebAssemlby] Add more expectations to test/MC/WebAssembly/comdat.ll
to
[WebAssemlby] Don't write COMDAT symbols as global imports
.
Jan 11 2018, 12:09 PM
sbc100
edited the summary of this revision.
(Show Details)
sbc100
added reviewers:
nwilson
,
dschuff
.
This revision was not accepted when it landed; it landed in state
Needs Review
.
Jan 11 2018, 12:36 PM
Closed by commit
rL322309: [WebAssemlby] MC: Don't write COMDAT symbols as global imports
(authored by
sbc
).
·
Explain Why
This revision was automatically updated to reflect the committed changes.
Herald
added a subscriber:
llvm-commits
.
·
View Herald Transcript
Jan 11 2018, 12:36 PM