Page MenuHomePhabricator

[Driver] Test for correct '--version' suggestion
ClosedPublic

Authored by modocache on Jan 10 2018, 11:29 AM.

Details

Summary

The llvm::OptTable::findNearest bug fixed in
https://reviews.llvm.org/D41873 manifested itself as the following
erroneous message when invoking Clang:

clang -version
clang-6.0: error: unknown argument '-version', did you mean 'version'?

Add a test to catch any future regressions to the now correct behavior,
which asks "did you mean '--version'?".

Test Plan: check-clang

Diff Detail

Repository
rC Clang

Event Timeline

modocache created this revision.Jan 10 2018, 11:29 AM
v.g.vassilev accepted this revision.Jan 10 2018, 11:36 AM

LGMT! We can rely on post-commit reviews for changes like this one.

This revision is now accepted and ready to land.Jan 10 2018, 11:36 AM
This revision was automatically updated to reflect the committed changes.

Thanks, will do next time :)