Page MenuHomePhabricator

yamaguchi (Yuka Takahashi)
Nya-nnyannyannya-nnyannyannya-nnyannyannyannyannyannyanNyannyannyannyannyannyannyan

Projects

User does not belong to any projects.

User Details

User Since
Mar 30 2017, 7:33 AM (119 w, 5 d)

Recent Activity

Jan 8 2019

yamaguchi added a comment to D56438: [Modules] Allow modulemap path change for implicitly built modules.

We have both explicitly and implicitly prebuilt modules, but this patch only relates to implicit ones. I agree that our usecase is a bit unique where we're installing and distributing implicitly built pcm, but I also imagine there might be a usecase where you built implicit pcms in some directory and want to reuse them somehow from other locations. If it doesn't make sense to be upstream, this can stay in our fork.

Jan 8 2019, 3:49 PM
yamaguchi created D56438: [Modules] Allow modulemap path change for implicitly built modules.
Jan 8 2019, 6:42 AM

Jan 7 2019

yamaguchi created D56390: Generate Checkers.inc under clang/Driver and use from CC1Options.td.
Jan 7 2019, 7:23 AM

Nov 5 2018

yamaguchi added a comment to D54097: Save memory in ASTReader by using DenseMap instead of vector.

FYI, raw benchmarking data:
https://gist.github.com/yamaguchi1024/4f28406f51b413129cc762365fdd76c8
https://gist.github.com/yamaguchi1024/318b30db03adb10b7b230b706012a14c

Nov 5 2018, 3:44 AM
yamaguchi created D54097: Save memory in ASTReader by using DenseMap instead of vector.
Nov 5 2018, 3:43 AM

Oct 24 2018

yamaguchi closed D53589: [bash-autocompletion] Fix bug when a flag ends with '='.

Landed in rL345121

Oct 24 2018, 5:47 AM
yamaguchi committed rC345133: [autocompletion] Handle the space before pressing tab.
[autocompletion] Handle the space before pressing tab
Oct 24 2018, 5:45 AM
yamaguchi committed rL345133: [autocompletion] Handle the space before pressing tab.
[autocompletion] Handle the space before pressing tab
Oct 24 2018, 5:45 AM
yamaguchi closed D53639: [autocompletion] Handle the space before pressing tab.
Oct 24 2018, 5:45 AM
yamaguchi closed D53639: [autocompletion] Handle the space before pressing tab.
Oct 24 2018, 5:45 AM
yamaguchi updated the diff for D53639: [autocompletion] Handle the space before pressing tab.

Updated HasSpace, added comments, fixed typo in the commit message

Oct 24 2018, 4:37 AM
yamaguchi created D53639: [autocompletion] Handle the space before pressing tab.
Oct 24 2018, 4:07 AM
yamaguchi committed rC345121: [bash-autocompletion] Fix bug when a flag ends with '='.
[bash-autocompletion] Fix bug when a flag ends with '='
Oct 24 2018, 1:28 AM
yamaguchi committed rL345121: [bash-autocompletion] Fix bug when a flag ends with '='.
[bash-autocompletion] Fix bug when a flag ends with '='
Oct 24 2018, 1:26 AM

Oct 23 2018

yamaguchi created D53589: [bash-autocompletion] Fix bug when a flag ends with '='.
Oct 23 2018, 10:20 AM

Sep 25 2018

yamaguchi created D52513: [Modules] Do not emit file modification error when -fno-validate-pch is set.
Sep 25 2018, 11:36 AM

Aug 1 2018

yamaguchi committed rC338503: [Modules] Do not emit relocation error when -fno-validate-pch is set.
[Modules] Do not emit relocation error when -fno-validate-pch is set
Aug 1 2018, 2:50 AM
yamaguchi committed rL338503: [Modules] Do not emit relocation error when -fno-validate-pch is set.
[Modules] Do not emit relocation error when -fno-validate-pch is set
Aug 1 2018, 2:50 AM
yamaguchi closed D49852: [Modules] Do not emit relocation error when -fno-validate-pch is set.
Aug 1 2018, 2:50 AM

Jul 26 2018

yamaguchi created D49852: [Modules] Do not emit relocation error when -fno-validate-pch is set.
Jul 26 2018, 7:09 AM

Jul 10 2018

yamaguchi committed rC336660: [modules] Fix 37878; Autoload subdirectory modulemaps with specific LangOpts.
[modules] Fix 37878; Autoload subdirectory modulemaps with specific LangOpts
Jul 10 2018, 5:22 AM
yamaguchi committed rL336660: [modules] Fix 37878; Autoload subdirectory modulemaps with specific LangOpts.
[modules] Fix 37878; Autoload subdirectory modulemaps with specific LangOpts
Jul 10 2018, 5:22 AM
yamaguchi closed D48367: [modules] Fix 37878; Autoload subdirectory modulemaps with specific LangOpts.
Jul 10 2018, 5:22 AM

Jun 26 2018

yamaguchi updated the summary of D48367: [modules] Fix 37878; Autoload subdirectory modulemaps with specific LangOpts.
Jun 26 2018, 5:55 AM
yamaguchi updated the diff for D48367: [modules] Fix 37878; Autoload subdirectory modulemaps with specific LangOpts.

Delete a.out)

Jun 26 2018, 5:53 AM
yamaguchi added inline comments to D48367: [modules] Fix 37878; Autoload subdirectory modulemaps with specific LangOpts.
Jun 26 2018, 5:51 AM
yamaguchi updated the diff for D48367: [modules] Fix 37878; Autoload subdirectory modulemaps with specific LangOpts.

Add #import test and add branch AllowExtraModuleMapSearch when ModuleName was from @import

Jun 26 2018, 5:51 AM

Jun 25 2018

yamaguchi updated the diff for D48367: [modules] Fix 37878; Autoload subdirectory modulemaps with specific LangOpts.

use %clang_cc1 instead of %clang

Jun 25 2018, 4:55 AM
yamaguchi added inline comments to D48367: [modules] Fix 37878; Autoload subdirectory modulemaps with specific LangOpts.
Jun 25 2018, 4:47 AM

Jun 21 2018

yamaguchi added inline comments to D48367: [modules] Fix 37878; Autoload subdirectory modulemaps with specific LangOpts.
Jun 21 2018, 2:04 AM
yamaguchi updated the diff for D48367: [modules] Fix 37878; Autoload subdirectory modulemaps with specific LangOpts.

Add a test case

Jun 21 2018, 2:00 AM

Jun 20 2018

yamaguchi updated the summary of D48367: [modules] Fix 37878; Autoload subdirectory modulemaps with specific LangOpts.
Jun 20 2018, 7:42 AM
yamaguchi updated the diff for D48367: [modules] Fix 37878; Autoload subdirectory modulemaps with specific LangOpts.

Update commmit message and comment, add ObjC2

Jun 20 2018, 7:41 AM
yamaguchi created D48367: [modules] Fix 37878; Autoload subdirectory modulemaps with specific LangOpts.
Jun 20 2018, 7:31 AM

May 23 2018

yamaguchi accepted D47273: [bash-completion] Fix tab separation on macOS.

LGTM

May 23 2018, 4:48 PM

Apr 26 2018

yamaguchi committed rC330946: Add getDeserializationListener to ASTReader.
Add getDeserializationListener to ASTReader
Apr 26 2018, 8:14 AM
yamaguchi committed rL330946: Add getDeserializationListener to ASTReader.
Add getDeserializationListener to ASTReader
Apr 26 2018, 8:14 AM
yamaguchi closed D45921: Add getDeserializationListener to ASTReader.
Apr 26 2018, 8:14 AM

Apr 25 2018

yamaguchi added a comment to D45921: Add getDeserializationListener to ASTReader.

Do you mean something like addDeserializationListener which create a multiplex listener with an existing listener? I think that'll be good as well!

Apr 25 2018, 2:42 AM

Apr 21 2018

yamaguchi created D45921: Add getDeserializationListener to ASTReader.
Apr 21 2018, 6:03 AM

Mar 16 2018

yamaguchi updated the diff for D44508: Remove unnecessary include from Driver.cpp.

@marsupial Thanks for the commment, found a bug in my script and fixed. Now this patch removes only includes which are not used in each TU.

Mar 16 2018, 1:32 AM

Mar 15 2018

yamaguchi updated the summary of D44509: Remove unnecessary includes from lld/ELF.
Mar 15 2018, 1:46 AM
yamaguchi created D44509: Remove unnecessary includes from lld/ELF.
Mar 15 2018, 1:42 AM
yamaguchi created D44508: Remove unnecessary include from Driver.cpp.
Mar 15 2018, 1:28 AM

Mar 7 2018

yamaguchi committed rC326889: Add Clang ReleaseNotes that --autocomplete breaks backward compatibily.
Add Clang ReleaseNotes that --autocomplete breaks backward compatibily
Mar 7 2018, 3:38 AM
yamaguchi committed rL326889: Add Clang ReleaseNotes that --autocomplete breaks backward compatibily.
Add Clang ReleaseNotes that --autocomplete breaks backward compatibily
Mar 7 2018, 3:38 AM
yamaguchi closed D44191: Add Clang ReleaseNotes that --autocomplete breaks backward compatibily.
Mar 7 2018, 3:38 AM
yamaguchi updated the diff for D44191: Add Clang ReleaseNotes that --autocomplete breaks backward compatibily.

Fixed typos

Mar 7 2018, 3:27 AM
yamaguchi created D44191: Add Clang ReleaseNotes that --autocomplete breaks backward compatibily.
Mar 7 2018, 12:47 AM

Mar 5 2018

yamaguchi committed rL326695: [www] Add a new proposal to OpenProjects.
[www] Add a new proposal to OpenProjects
Mar 5 2018, 5:05 AM
yamaguchi committed rL326685: [Bash-autocompletion] Fixed formatting.
[Bash-autocompletion] Fixed formatting
Mar 5 2018, 1:04 AM
yamaguchi committed rC326685: [Bash-autocompletion] Fixed formatting.
[Bash-autocompletion] Fixed formatting
Mar 5 2018, 1:04 AM
yamaguchi committed rC326684: [Bash-autocompletion] Pass all flags in shell command-line to Clang.
[Bash-autocompletion] Pass all flags in shell command-line to Clang
Mar 5 2018, 12:58 AM
yamaguchi committed rL326684: [Bash-autocompletion] Pass all flags in shell command-line to Clang.
[Bash-autocompletion] Pass all flags in shell command-line to Clang
Mar 5 2018, 12:57 AM
yamaguchi closed D39342: [Bash-autocompletion] Pass all flags in shell command-line to Clang.
Mar 5 2018, 12:57 AM

Nov 19 2017

yamaguchi accepted D40234: [AutoComplete] Use stronger sort predicate for autocomplete candidates to remove non-deterministic ordering.

LGTM, thanks!

Nov 19 2017, 9:22 PM · Restricted Project

Nov 3 2017

yamaguchi updated the diff for D39342: [Bash-autocompletion] Pass all flags in shell command-line to Clang.

Made a trivial fix in the testcase

Nov 3 2017, 3:08 AM
yamaguchi updated the summary of D39342: [Bash-autocompletion] Pass all flags in shell command-line to Clang.
Nov 3 2017, 3:06 AM
yamaguchi updated the diff for D39342: [Bash-autocompletion] Pass all flags in shell command-line to Clang.

Update diff. Pass all flags just with "," including values.

Nov 3 2017, 2:37 AM

Oct 27 2017

yamaguchi added inline comments to D39342: [Bash-autocompletion] Pass all flags in shell command-line to Clang.
Oct 27 2017, 4:57 PM

Oct 26 2017

yamaguchi created D39342: [Bash-autocompletion] Pass all flags in shell command-line to Clang.
Oct 26 2017, 1:23 PM

Sep 5 2017

yamaguchi accepted D37465: [Bash-autocomplete] Fix crash when invoking --autocomplete without value..

LGTM! Thanks for the fix!

Sep 5 2017, 5:09 AM

Aug 29 2017

yamaguchi committed rL312018: [Bash-autocomplete] Refactor autocomplete code into own function.
[Bash-autocomplete] Refactor autocomplete code into own function
Aug 29 2017, 10:49 AM
yamaguchi closed D37249: [Bash-autocomplete] Refactor autocomplete code into own function by committing rL312018: [Bash-autocomplete] Refactor autocomplete code into own function.
Aug 29 2017, 10:49 AM

Aug 28 2017

yamaguchi updated the diff for D37249: [Bash-autocomplete] Refactor autocomplete code into own function.

Update diff. I agree that this is more generic.

Aug 28 2017, 11:30 PM
yamaguchi created D37249: [Bash-autocomplete] Refactor autocomplete code into own function.
Aug 28 2017, 9:51 PM
yamaguchi abandoned D37203: [Bash-autocompletion] Follow up patch for D36782.

D37217 has already landed, so we don't need this anymore.

Aug 28 2017, 8:22 PM
yamaguchi committed rL311971: [Bash-autocompletion] Add support for -std=.
[Bash-autocompletion] Add support for -std=
Aug 28 2017, 7:03 PM
yamaguchi closed D36820: [Bash-autocompletion] Add support for -std= by committing rL311971: [Bash-autocompletion] Add support for -std=.
Aug 28 2017, 7:03 PM
yamaguchi committed rL311958: Revert "Revert r311552: [Bash-autocompletion] Add support for static analyzer….
Revert "Revert r311552: [Bash-autocompletion] Add support for static analyzer…
Aug 28 2017, 5:11 PM
yamaguchi accepted D37217: Keep an instance of COFFOptTable alive as long as InputArgList is alive..

I think this way is more reasonable than mine. Thank you very much!

Aug 28 2017, 12:51 PM
yamaguchi created D37203: [Bash-autocompletion] Follow up patch for D36782.
Aug 28 2017, 2:04 AM

Aug 23 2017

yamaguchi committed rL311552: [Bash-autocompletion] Add support for static analyzer flags.
[Bash-autocompletion] Add support for static analyzer flags
Aug 23 2017, 6:41 AM
yamaguchi closed D36782: [Bash-autocompletion] Add support for static analyzer flags by committing rL311552: [Bash-autocompletion] Add support for static analyzer flags.
Aug 23 2017, 6:41 AM

Aug 18 2017

yamaguchi added a comment to D36782: [Bash-autocompletion] Add support for static analyzer flags.

@ruiu
I addressed your comments in D36820, so please take a look at it. Thank you!

Aug 18 2017, 10:53 PM
yamaguchi updated the diff for D36820: [Bash-autocompletion] Add support for -std=.

Update diff. Thank you for your comments!

Aug 18 2017, 10:47 PM
yamaguchi added inline comments to D36820: [Bash-autocompletion] Add support for -std=.
Aug 18 2017, 10:46 PM

Aug 17 2017

yamaguchi updated the diff for D36820: [Bash-autocompletion] Add support for -std=.

Update diff.

Aug 17 2017, 9:32 PM
yamaguchi added inline comments to D36820: [Bash-autocompletion] Add support for -std=.
Aug 17 2017, 1:05 PM
yamaguchi updated the diff for D36820: [Bash-autocompletion] Add support for -std=.

Update diff.

Aug 17 2017, 1:03 PM
yamaguchi updated the diff for D36782: [Bash-autocompletion] Add support for static analyzer flags.

const char* Values -> const char *Values

Aug 17 2017, 1:01 PM
yamaguchi updated the diff for D36782: [Bash-autocompletion] Add support for static analyzer flags.

Update diff.

Aug 17 2017, 12:59 PM

Aug 16 2017

yamaguchi created D36820: [Bash-autocompletion] Add support for -std=.
Aug 16 2017, 11:55 PM
yamaguchi added a comment to D36782: [Bash-autocompletion] Add support for static analyzer flags.

@ruiu
I understand your concern. However by doing this (rather than building functions for each flag), we will be able to get all information in OptTable itself. It is true that this is quite fragile, but adding ValuesCode to new flag is not complicated, so I believe overall it's fine.

Aug 16 2017, 8:01 PM
yamaguchi updated the diff for D36782: [Bash-autocompletion] Add support for static analyzer flags.

Update diff.

Aug 16 2017, 7:44 PM
yamaguchi updated the diff for D36782: [Bash-autocompletion] Add support for static analyzer flags.

Update diff according to Raphael's comments.

Aug 16 2017, 1:27 AM

Aug 15 2017

yamaguchi created D36782: [Bash-autocompletion] Add support for static analyzer flags.
Aug 15 2017, 11:49 PM

Aug 11 2017

yamaguchi committed rL310700: [Bash-autocompletion] Add --autocomplete flag to 5.0 release notes.
[Bash-autocompletion] Add --autocomplete flag to 5.0 release notes
Aug 11 2017, 2:45 AM
yamaguchi closed D36567: [Bash-autocompletion] Add --autocomplete flag to 5.0 release notes by committing rL310700: [Bash-autocompletion] Add --autocomplete flag to 5.0 release notes.
Aug 11 2017, 2:45 AM

Aug 9 2017

yamaguchi created D36567: [Bash-autocompletion] Add --autocomplete flag to 5.0 release notes.
Aug 9 2017, 10:43 PM

Aug 2 2017

yamaguchi committed rL309794: [Bash-autocompletion] Add comment to test so that it is easier to fix.
[Bash-autocompletion] Add comment to test so that it is easier to fix
Aug 2 2017, 12:21 AM
yamaguchi closed D36209: [Bash-autocompletion] Add comment to test so that it is easier to fix by committing rL309794: [Bash-autocompletion] Add comment to test so that it is easier to fix.
Aug 2 2017, 12:21 AM
yamaguchi updated the diff for D36209: [Bash-autocompletion] Add comment to test so that it is easier to fix.

Fixed typo.

Aug 2 2017, 12:01 AM

Aug 1 2017

yamaguchi updated the diff for D36209: [Bash-autocompletion] Add comment to test so that it is easier to fix.

Modified comment.

Aug 1 2017, 11:57 PM
yamaguchi added a comment to D36209: [Bash-autocompletion] Add comment to test so that it is easier to fix.

@ruiu
This test will break for instance, when someone add new value to mrelocation-model because values has to be shown in row 78- 83 order, or when someone made a new flag which start with -Wno-invalid-pp- because in row 96 only -Wno-invalid-pp-token is expected for this prefix.

Aug 1 2017, 11:17 PM
yamaguchi updated the diff for D36209: [Bash-autocompletion] Add comment to test so that it is easier to fix.

Update diff.

Aug 1 2017, 11:10 PM
yamaguchi created D36209: [Bash-autocompletion] Add comment to test so that it is easier to fix.
Aug 1 2017, 10:45 PM

Jul 26 2017

yamaguchi committed rL309113: [Bash-autocompletion] Show HelpText with possible flags.
[Bash-autocompletion] Show HelpText with possible flags
Jul 26 2017, 6:37 AM
yamaguchi closed D35759: [Bash-autocompletion] Show HelpText with possible flags by committing rL309113: [Bash-autocompletion] Show HelpText with possible flags.
Jul 26 2017, 6:37 AM
yamaguchi committed rL309112: [Bash-completion] Fixed a bug that file doesn't autocompleted after =.
[Bash-completion] Fixed a bug that file doesn't autocompleted after =
Jul 26 2017, 6:32 AM