And also enable it by default to be consistent with e.g. modernize-use-using. This helps e.g. when running this check on client code where the macro is provided by the system, so there is no easy way to modify it.
Details
Details
- Reviewers
alexfh piotrdz hokein ilya-biryukov - Commits
- rG063e6cc5e706: clang-tidy: add IgnoreMacros option to readability-inconsistent-declaration…
rCTE321913: clang-tidy: add IgnoreMacros option to readability-inconsistent-declaration…
rL321913: clang-tidy: add IgnoreMacros option to readability-inconsistent-declaration…
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
And also enable it by default to be consistent with e.g. modernize-use-using.
That changes the defaults though. I thought clang-tidy *tried* to produce the same results
on different clang-tidy versions with the same .clang-tidy config? Or is there no such guarantees?
Comment Actions
Hmm, I see this as a trade-off between backwards compatibility and consistency. Here I went for consistency, so that all of readability-inconsistent-declaration-parameter-name, modernize-use-default-member-init and modernize-use-using default to IgnoreMacros=1. But I don't have a too strong opinion on that, can change the default to 0 if really wanted,
Comment Actions
I'd personally prefer consistency in this case, especially because the option can be specified globally for all checks.