Simplify handling of size relocations

[• espindola]

Summary

This is possible now that getSize is not a template.

[atanasyan]

LGTM

[• espindola]

r321900.

ELF/InputSection.cpp

if (Sym.isTls() && Sym.isUndefWeak())
       return 0;
     if (Target->TcbSize)
       return Sym.getVA(A) + alignTo(Target->TcbSize, Out::TlsPhdr->p_align);
     return Sym.getVA(A) - Out::TlsPhdr->p_memsz;
   case R_RELAX_TLS_GD_TO_LE_NEG:
   case R_NEG_TLS:
     return Out::TlsPhdr->p_memsz - Sym.getVA(A);
   case R_SIZE:
-    return A; // Sym.getSize was already folded into the addend.
+    return Sym.getSize() + A;
   case R_TLSDESC:
     return InX::Got->getGlobalDynAddr(Sym) + A;
   case R_TLSDESC_PAGE:
     return getAArch64Page(InX::Got->getGlobalDynAddr(Sym) + A) -
            getAArch64Page(P);
   case R_TLSGD:
     return InX::Got->getGlobalDynOffset(Sym) + A - InX::Got->getSize();
   case R_TLSGD_PC:

ELF/Relocations.cpp

if (!needsPlt(Expr) && !needsGot(Expr) && Sym.IsPreemptible) {
       // to the GOT entry and reads the GOT entry when it needs to perform
       // a dynamic relocation.
       // ftp://www.linux-mips.org/pub/linux/mips/doc/ABI/mipsabi.pdf p.4-19
       if (Config->EMachine == EM_MIPS)
         InX::MipsGot->addEntry(Sym, Addend, Expr);
       continue;
     }
 
-    // The size is not going to change, so we fold it in here.
-    if (Expr == R_SIZE)
-      Addend += Sym.getSize();
-
     // If the produced value is a constant, we just remember to write it
     // when outputting this section. We also have to do it if the format
     // uses Elf_Rel, since in that case the written value is the addend.
     if (IsConstant) {
       Sec.Relocations.push_back({Expr, Type, Offset, Addend, &Sym});
       continue;
     }