Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D41645

Move scanReloc to an auxiliary function
ClosedPublic
Actions

Authored by • espindola on Dec 30 2017, 8:26 PM.

Tags

None

Subscribers

Details

Reviewers

ruiu
grimar
smeenai
atanasyan

Summary

The body of the in scanRelocs is fairly big. This moves it to its own function.

It is not a big readability win by itself, but should help further refactoring.

Diff Detail

Event Timeline

• espindola created this revision.Dec 30 2017, 8:26 PM

Herald added a subscriber: emaste. · View Herald TranscriptDec 30 2017, 8:26 PM

• espindola updated this revision to Diff 128587.Jan 3 2018, 5:27 PM

• espindola added reviewers: grimar, smeenai.

• espindola added a child revision: D41770: Rewrite our relocation processing.Jan 5 2018, 11:32 AM

• espindola added parent revisions: D41690: Simplify handling of size relocations, D41681: Centralize Config->IsRela handling.Jan 5 2018, 11:39 AM

• espindola added a reviewer: atanasyan.Jan 5 2018, 11:42 AM

Rebased.

Seems like a straightforward NFC refactoring. LGTM.

This revision is now accepted and ready to land.Jan 5 2018, 8:17 PM

LGTM

r322035

LGTM

Revision Contents
Changeset List

Path

Size

ELF/

Relocations.cpp

301 lines

Diff 128790

ELF/Relocations.cpp

Loading...