Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D41681

Centralize Config->IsRela handling
ClosedPublic
Actions

Authored by • espindola on Jan 2 2018, 1:40 PM.

Details

Reviewers
ruiu
grimar
smeenai
atanasyan
Summary

This merges the two places were we check Config->IsRela to decide how to write a relocation addend.

Diff Detail

Event Timeline

• espindola created this revision.Jan 2 2018, 1:40 PM
Herald added a subscriber: emaste. · View Herald TranscriptJan 2 2018, 1:40 PM
• espindola updated this revision to Diff 128585.Jan 3 2018, 5:16 PM

Avoid changes to DynamicReloc.

• espindola added a reviewer: smeenai.Jan 3 2018, 5:17 PM
• espindola added a child revision: D41645: Move scanReloc to an auxiliary function.Jan 5 2018, 11:39 AM
• espindola added a reviewer: atanasyan.Jan 5 2018, 11:41 AM
atanasyan accepted this revision.Jan 5 2018, 12:02 PM

LGTM

This revision is now accepted and ready to land.Jan 5 2018, 12:02 PM
• espindola closed this revision.Jan 5 2018, 12:12 PM

r321889

Revision Contents
Changeset List

Diff 128457

View Options

ELF/Relocations.cpp

Loading...
View Options

ELF/SyntheticSections.h

Loading...
View Options

ELF/SyntheticSections.cpp

Loading...