This is an archive of the discontinued LLVM Phabricator instance.

Differential D41677

Change memcpy/memove/memset to have dest and source alignment attributes.
ClosedPublic

Authored by dneilson on Jan 2 2018, 12:06 PM.

Details

Reviewers
rjmccall
Commits
rG77a98366ce25: Change memcpy/memove/memset to have dest and source alignment attributes.
rGc8bdc8db73e2: Change memcpy/memove/memset to have dest and source alignment attributes.
rPLO323618: Change memcpy/memove/memset to have dest and source alignment attributes.
rL323618: Change memcpy/memove/memset to have dest and source alignment attributes.
rC323617: Change memcpy/memove/memset to have dest and source alignment attributes.
rL323617: Change memcpy/memove/memset to have dest and source alignment attributes.
Summary

Upstream LLVM is changing the the prototypes of the @llvm.memcpy/memmove/memset
intrinsics. This change updates the Clang CGBuilder and the Clang tests
for this change.

The @llvm.memcpy/memmove/memset intrinsics currently have an explicit argument
which is required to be a constant integer. It represents the alignment of the
dest (and source), and so must be the minimum of the actual alignment of the
two.

This change allows source and dest to each have their own alignments by
using the alignment attribute on their arguments. The alignment argument
is removed.

For example, code which used to read:
call void @llvm.memcpy.p0i8.p0i8.i32(i8* %dest, i8* %src, i32 100, i32 4, i1 false)
will now read
call void @llvm.memcpy.p0i8.p0i8.i32(i8* align 4 %dest, i8* align 4 %src, i32 100, i1 false)

Diff Detail

Event Timeline

dneilson created this revision.Jan 2 2018, 12:06 PM
Herald added subscribers: fedor.sergeev, kbarton, aheejin and 5 others. · View Herald TranscriptJan 2 2018, 12:06 PM
dneilson added a parent revision: D41675: Remove alignment argument from memcpy/memmove/memset in favour of alignment attributes (Step 1).Jan 2 2018, 12:06 PM
rjmccall accepted this revision.Jan 2 2018, 12:47 PM

I'm glad to hear that progress is finally happening on this.

The change to CGBuilder looks good to me. I'm going to take your word for it that the test changes are all just obvious updates; if there's one in particular that you'd like me to look at, I'd be happy to.

This revision is now accepted and ready to land.Jan 2 2018, 12:47 PM
dneilson added a comment.Jan 2 2018, 12:51 PM
In D41677#966094, @rjmccall wrote:

I'm glad to hear that progress is finally happening on this.

The change to CGBuilder looks good to me. I'm going to take your word for it that the test changes are all just obvious updates; if there's one in particular that you'd like me to look at, I'd be happy to.

Thanks! Yeah, the CGBuilder change is the meat of it. The test changes are all either sed-script changes, or manual fixes. For the manual fixes I made an effort to make sure that if the test wasn't checking for a specific alignment value before this change then it won't be checking for a specific alignment value after it either (i.e. matches like align {{[0-9]+}} when the alignment value doesn't matter).

dneilson updated this revision to Diff 131685.Jan 27 2018, 10:04 AM

Rebaseline

Harbormaster completed remote builds in B14302: Diff 131685.Jan 27 2018, 10:04 AM
Herald added subscribers: niosHD, sabuasal, apazos and 5 others. · View Herald TranscriptJan 27 2018, 10:04 AM
rjmccall accepted this revision.Jan 27 2018, 9:23 PM

Still LGTM.

Closed by commit rL323617: Change memcpy/memove/memset to have dest and source alignment attributes. (authored by dneilson). · Explain WhyJan 28 2018, 9:29 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptJan 28 2018, 9:29 AM

Large Diff

This large diff affects 118 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents

PathSize
lib/
CodeGen/
18 lines
test/
CodeGen/
2 lines
2 lines
8 lines
648 lines
672 lines
108 lines
24 lines
12 lines
4 lines
2 lines
444 lines
2 lines
6 lines
10 lines
30 lines
32 lines
4 lines
2 lines
4 lines
10 lines
10 lines
6 lines
16 lines
2 lines
12 lines
10 lines
2 lines
2 lines
10 lines
4 lines
4 lines
8 lines
56 lines
2 lines
2 lines
4 lines
CodeGenCXX/
14 lines
30 lines
4 lines
2 lines
6 lines
4 lines
2 lines
2 lines
2 lines
2 lines
8 lines
2 lines
2 lines
4 lines
20 lines
10 lines
12 lines
68 lines
4 lines
4 lines
2 lines
CodeGenObjC/
2 lines
6 lines
2 lines
4 lines
2 lines
CodeGenObjCXX/
2 lines
CodeGenOpenCL/
2 lines
10 lines
4 lines
2 lines
Modules/
4 lines
OpenMP/
4 lines
12 lines
16 lines
16 lines
28 lines
16 lines
28 lines
12 lines
16 lines
4 lines
4 lines
36 lines
10 lines
4 lines
4 lines
12 lines
8 lines
24 lines
4 lines
2 lines
12 lines
2 lines
4 lines
28 lines
28 lines
16 lines
4 lines
16 lines
4 lines
16 lines
28 lines
4 lines
4 lines
8 lines
4 lines
16 lines
4 lines
4 lines
16 lines
4 lines
4 lines
16 lines
8 lines
28 lines
8 lines
28 lines
4 lines
16 lines
8 lines

Diff 128444

lib/CodeGen/CGBuilder.h

test/CodeGen/2007-11-07-CopyAggregateAlign.c

test/CodeGen/2007-11-07-ZeroAggregateAlign.c

test/CodeGen/64bit-swiftcall.c

test/CodeGen/aarch64-neon-intrinsics.c

test/CodeGen/aarch64-neon-ldst-one.c

test/CodeGen/aarch64-neon-perm.c

test/CodeGen/aarch64-poly64.c

test/CodeGen/aarch64-v8.2a-neon-intrinsics.c

test/CodeGen/arm-arguments.c

test/CodeGen/arm64-be-bitfield.c

test/CodeGen/arm_neon_intrinsics.c

test/CodeGen/atomic-arm64.c

test/CodeGen/block-byref-aggr.c

test/CodeGen/builtin-memfns.c

test/CodeGen/c11atomics-ios.c

test/CodeGen/c11atomics.c

test/CodeGen/compound-literal.c

test/CodeGen/le32-vaarg.c

test/CodeGen/ms-intrinsics.c

test/CodeGen/no-opt-volatile-memcpy.c

test/CodeGen/packed-nest-unpacked.c

test/CodeGen/packed-structure.c

test/CodeGen/partial-reinitialization2.c

test/CodeGen/ppc-varargs-struct.c

test/CodeGen/ppc64-align-struct.c

test/CodeGen/ppc64-soft-float.c

test/CodeGen/ppc64le-aggregates.c

test/CodeGen/sparc-vaarg.c

test/CodeGen/tbaa-struct.cpp

test/CodeGen/volatile.c

test/CodeGen/wasm-varargs.c

test/CodeGen/windows-swiftcall.c

test/CodeGen/x86-atomic-long_double.c

test/CodeGen/x86_32-arguments-realign.c

test/CodeGen/x86_64-arguments.c

test/CodeGen/xcore-abi.c

test/CodeGenCXX/alignment.cpp

test/CodeGenCXX/assign-construct-memcpy.cpp

test/CodeGenCXX/constructor-direct-call.cpp

test/CodeGenCXX/copy-constructor-elim.cpp

test/CodeGenCXX/copy-constructor-synthesis-2.cpp

test/CodeGenCXX/copy-constructor-synthesis.cpp

test/CodeGenCXX/cxx0x-delegating-ctors.cpp

test/CodeGenCXX/cxx0x-initializer-array.cpp

test/CodeGenCXX/cxx11-initializer-array-new.cpp

test/CodeGenCXX/cxx1z-lambda-star-this.cpp

test/CodeGenCXX/eh.cpp

test/CodeGenCXX/float16-declarations.cpp

test/CodeGenCXX/microsoft-abi-sret-and-byval.cpp

test/CodeGenCXX/microsoft-abi-virtual-inheritance.cpp

test/CodeGenCXX/microsoft-uuidof.cpp

test/CodeGenCXX/new-array-init.cpp

test/CodeGenCXX/no-opt-volatile-memcpy.cpp

test/CodeGenCXX/pod-member-memcpys.cpp

test/CodeGenCXX/pr20897.cpp

test/CodeGenCXX/value-init.cpp

test/CodeGenCXX/varargs.cpp

test/CodeGenObjC/arc-foreach.m

test/CodeGenObjC/arc.m

test/CodeGenObjC/builtin-memfns.m

test/CodeGenObjC/messages-2.m

test/CodeGenObjC/stret-1.m

test/CodeGenObjCXX/arc-exceptions.mm

test/CodeGenOpenCL/amdgcn-automatic-variable.cl

test/CodeGenOpenCL/amdgpu-nullptr.cl

test/CodeGenOpenCL/partial_initializer.cl

test/CodeGenOpenCL/private-array-initialization.cl

test/Modules/templates.mm

test/OpenMP/atomic_write_codegen.c

test/OpenMP/distribute_firstprivate_codegen.cpp

test/OpenMP/distribute_lastprivate_codegen.cpp

test/OpenMP/distribute_parallel_for_firstprivate_codegen.cpp

test/OpenMP/distribute_parallel_for_lastprivate_codegen.cpp

test/OpenMP/distribute_parallel_for_simd_firstprivate_codegen.cpp

test/OpenMP/distribute_parallel_for_simd_lastprivate_codegen.cpp

test/OpenMP/distribute_simd_firstprivate_codegen.cpp

test/OpenMP/distribute_simd_lastprivate_codegen.cpp

test/OpenMP/for_firstprivate_codegen.cpp

test/OpenMP/for_lastprivate_codegen.cpp

test/OpenMP/for_reduction_codegen.cpp

test/OpenMP/nvptx_target_firstprivate_codegen.cpp

test/OpenMP/ordered_doacross_codegen.cpp

test/OpenMP/parallel_codegen.cpp

test/OpenMP/parallel_copyin_codegen.cpp

test/OpenMP/parallel_firstprivate_codegen.cpp

test/OpenMP/parallel_reduction_codegen.cpp

test/OpenMP/sections_firstprivate_codegen.cpp

test/OpenMP/sections_lastprivate_codegen.cpp

test/OpenMP/sections_reduction_codegen.cpp

test/OpenMP/single_codegen.cpp

test/OpenMP/single_firstprivate_codegen.cpp

test/OpenMP/target_enter_data_depend_codegen.cpp

test/OpenMP/target_exit_data_depend_codegen.cpp

test/OpenMP/target_firstprivate_codegen.cpp

test/OpenMP/target_teams_distribute_firstprivate_codegen.cpp

test/OpenMP/target_teams_distribute_lastprivate_codegen.cpp

test/OpenMP/target_teams_distribute_simd_firstprivate_codegen.cpp

test/OpenMP/target_teams_distribute_simd_lastprivate_codegen.cpp

test/OpenMP/target_update_depend_codegen.cpp

test/OpenMP/task_codegen.cpp

test/OpenMP/task_firstprivate_codegen.cpp

test/OpenMP/taskgroup_task_reduction_codegen.cpp

test/OpenMP/taskloop_firstprivate_codegen.cpp

test/OpenMP/taskloop_lastprivate_codegen.cpp

test/OpenMP/taskloop_reduction_codegen.cpp

test/OpenMP/taskloop_simd_firstprivate_codegen.cpp

test/OpenMP/taskloop_simd_lastprivate_codegen.cpp

test/OpenMP/taskloop_simd_reduction_codegen.cpp

test/OpenMP/teams_distribute_firstprivate_codegen.cpp

test/OpenMP/teams_distribute_lastprivate_codegen.cpp

test/OpenMP/teams_distribute_parallel_for_firstprivate_codegen.cpp

test/OpenMP/teams_distribute_parallel_for_lastprivate_codegen.cpp

test/OpenMP/teams_distribute_parallel_for_simd_firstprivate_codegen.cpp

test/OpenMP/teams_distribute_parallel_for_simd_lastprivate_codegen.cpp

test/OpenMP/teams_distribute_simd_firstprivate_codegen.cpp

test/OpenMP/teams_distribute_simd_lastprivate_codegen.cpp

test/OpenMP/teams_firstprivate_codegen.cpp