See bugzilla: http://llvm.org/bugs/show_bug.cgi?id=20056
Overall this looks good to me, but I think we should split this into two commits: 1 factoring commit that moves the constant pools to a place that can be accessed by both AArch64 and ARM backends, and a second commit to implement the ldr= psuedo for AArch64.
|1 ↗||(On Diff #10456)|
Either add the corresponding test for darwin, or delete this comment. I'm not sure if it is applicable for aarch64, or if the syntax is now unified between linux and darwin.
LGTM with a suitable commit message explaining why we want to split out the implementation.
Minor cleanup, otherwise LGTM.
As a suggestion for the future I think it would be better to start a new differential revision for each patch. Also, if you add "Differential Revison: <url>" to the commit message it will close it automatically on commit.
|3031 ↗||(On Diff #10583)|
use cast<> instead of dyn_cast<> when not checking the return value for null.