- User Since
- Jan 24 2014, 9:55 AM (282 w, 3 d)
Jan 13 2015
Jan 12 2015
I added a test case and also an explanation in the commit message on when we can hit this problem.
Added test case and fixed commit message.
Jan 9 2015
Nov 7 2014
Oct 30 2014
Oct 22 2014
Oct 21 2014
Oct 15 2014
Oct 14 2014
This patch makes me nervous because I don't see why it is obviously safe to always promote to the next size without changing semantics. For example, with this loop:
This looks like a nice cleanup to me. I think centralizing the available options for polly makes sense. The major downside in my opinion is that we now have a bunch of global variables. Previously you could look at a command line option that is declared static (without external storage) and know it is only used in that file. Now we are exposing these all as global variables.
Oct 9 2014
Oct 2 2014
Needs test case. Otherwise LGTM.
LGTM with small test case demonstrating the command line option is respected.
Oct 1 2014
LGTM. Could also fold the alignment setting into the creation.
Sep 26 2014
Sep 25 2014
Sep 24 2014
Sep 23 2014
Sep 17 2014
Sep 15 2014
Sep 12 2014
Sep 11 2014
Updated test case to a simplified loop so that is easier to see why it causes a failure.
Sep 10 2014
Needs a test case to demonstrate the omission of the guard bb. Otherwise, LGTM.
Sep 9 2014
Sep 8 2014
As far as I know detailed mod-ref-behaviour is currently only returned in the case of intrinsic functions. These functions are defined with the appropriate values and tablegen generates some code to return the correct values. You could use an intrinsic function in your test (e.g. llvm.prefetch).
Minor typo. Otherwise the patch looks reasonable to me.
Jul 18 2014
Jul 17 2014
For completeness I would add one more test for loading a smaller constant to an x register to show that we generate a 64-bit entry in the constant pool even if the value does not require the full 64-bits. You don't need another review for that change.
Thanks, this is looking much better. I had one minor suggestion and a question about the APInt usage.
Jul 14 2014
Thanks for the patch. Overall I like the direction you are going. Please see specific comments below.
Jun 24 2014
It's not clear to me how this change improves the test. Rather than just renaming, I think it would be better to
Jun 23 2014
Jun 20 2014
Minor cleanup, otherwise LGTM.
Adding llvm-commits to CC.
Some minor c++11 suggestions. LGTM with those changes.
Jun 17 2014
LGTM with a suitable commit message explaining why we want to split out the implementation.
Adding llvm-commits to CC.
Overall this looks good to me, but I think we should split this into two commits: 1 factoring commit that moves the constant pools to a place that can be accessed by both AArch64 and ARM backends, and a second commit to implement the ldr= psuedo for AArch64.