Page MenuHomePhabricator

[DAGCombine] Fix for PR35763
ClosedPublic

Authored by samparker on Dec 29 2017, 4:52 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

samparker created this revision.Dec 29 2017, 4:52 AM
RKSimon added a subscriber: RKSimon.
RKSimon added inline comments.
test/CodeGen/X86/pr35763.ll
1 ↗(On Diff #128329)

Please use utils\update_llc_test_checks.py to regenerate the checks

samparker updated this revision to Diff 128335.Dec 29 2017, 7:09 AM

Thanks Simon, I've updated the test.

Does pr35763.ll reduce any further?

Not simply, the original test case is a bit odd and the bug easily fails to trigger. Any particular reason for not using the original reduced test case?

Not simply, the original test case is a bit odd and the bug easily fails to trigger. Any particular reason for not using the original reduced test case?

Just that more complex test cases can sometimes result in the underlying issue it was testing being 'hidden' by future (unrelated) patches, the simpler the test case the better likelihood that we're still testing for the same thing.

Please can you commit pr35763.ll with the trunk's current codegen and then update this patch just to show the codegen diff?

Ok. I haven't got commit access right now, but I'll do it first thing tomorrow morning.

samparker updated this revision to Diff 128606.Jan 4 2018, 2:39 AM

Committed pr37563.ll so this patch can show the changes.

RKSimon accepted this revision.Jan 4 2018, 8:51 AM

LGTM - thanks

This revision is now accepted and ready to land.Jan 4 2018, 8:51 AM
This revision was automatically updated to reflect the committed changes.