Page MenuHomePhabricator

dbabokin (Dmitry Babokin)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 1 2014, 4:43 AM (376 w, 6 d)

Recent Activity

Wed, Sep 8

dbabokin added a comment to D99170: [CMake] try creating symlink first on windows.

I confirm that it is a problem with 7zip, which is not preserving symlinks by default. Thanks for pointing to it.
The reason why this commit "broke" it for us, is because it introduced symlinks on Windows.
I'm still not sure that using symlinks on Windows is a good idea, given how poorly they are supported by the ecosystem.

Wed, Sep 8, 4:13 PM · Restricted Project

Fri, Sep 3

dbabokin added a comment to D99170: [CMake] try creating symlink first on windows.

Note, there's a bug caused by these changes: LLVM bug 51692
TLDR: in Github Action (Windows) environment compiler builds "successfully", but links are broken and no copy is done.

Fri, Sep 3, 10:16 AM · Restricted Project

Apr 28 2021

dbabokin added a comment to D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable.

Thanks for the report. It seems the thing to do is to modify the warning so that variables marked extern are not candidates for this warning. I will make a new commit with that modification unless there are other suggestions.

Apr 28 2021, 10:22 AM · Restricted Project, Restricted Project, Restricted Project

Apr 27 2021

dbabokin added a comment to D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable.

One more false-positive:

void foo() {
  extern int yydebug;
  yydebug = 1;
}
Apr 27 2021, 9:36 PM · Restricted Project, Restricted Project, Restricted Project

Sep 1 2020

dbabokin added a comment to D86507: [MachineCopyPropagation] In isNopCopy, check the destination registers match in addition to the source registers..

Would be good to have it merged to 11.0.

Sep 1 2020, 11:59 AM · Restricted Project

Aug 15 2017

dbabokin added a comment to D36643: [DAGCombine] Make CombineTo prune nodes more aggressively..

I've run it through 1.6M tests on x86 (-O3) and found nothing. This makes me pretty sure that my run will not find anything new in reasonable time.

Aug 15 2017, 10:48 AM

Aug 11 2017

dbabokin added a comment to D36581: [DAG] Fix Node Replacement in PromoteIntBinOp.

I also have a patch that more aggressively causes invalidation-based assertions where latent bugs may lie; I think it'll catch the lion share of the latent bugs.

Aug 11 2017, 1:26 PM

Apr 4 2017

dbabokin added a comment to D31625: [SDAG] Fix CombineTo ordering in visitZERO_EXTEND and visitSIGN_EXTEND.

I still see 19 fails with current patch. All the remaining fails that I have are reduced and attached to 32284 as third attachment.

Apr 4 2017, 5:52 PM

Oct 2 2015

dbabokin added a comment to D12456: [IR] Add operand bundles to CallInst and InvokeInst..

Thanks for the fix, it works.

Oct 2 2015, 3:11 AM

Oct 1 2015

dbabokin added a comment to D12456: [IR] Add operand bundles to CallInst and InvokeInst..

Your comment in include/llvm/IR/InstrTypes.h in line 1137 is undeniably
nice, but it causes a warning (or an error when building with "-Wall"):

Oct 1 2015, 5:24 AM

Jul 1 2014

dbabokin retitled D4354: Bugs in SemaOverload.cpp from to Bugs in SemaOverload.cpp.
Jul 1 2014, 4:56 AM