[OMPT] Add Workaround for Intel Compiler Bug

[sconvent]

Summary

Add Workaround for Intel Compiler Bug with Case#: 03138964

A critical region within a nested task causes a segfault in icc 14-18:

#include <stdio.h>
int main()
{
  #pragma omp parallel num_threads(2)
  #pragma omp master
    #pragma omp task
      #pragma omp task
        #pragma omp critical
          printf("test\n");
}

When the critical region is in a separate function, the segault does not occur.

[omalyshe]

icc bug

What bug it is and which version of ICC is affected?

[Hahnfeld]

In D41182#955383, @omalyshe wrote:

icc bug

What bug it is and which version of ICC is affected?

Yes, this change also deserves a description of why this is needed. It also looks like the fuzzy address and noinline are two different problems that should be addressed separately.

runtime/test/ompt/tasks/task_types.c

15 ↗

(On Diff #126754)

This should not be needed, format_task_type uses sprintf which automatically appends a null character.

runtime/test/ompt/tasks/task_types_serialized.c

14 ↗

(On Diff #126754)

Same

[protze.joachim]

In D41182#955383, @omalyshe wrote:

icc bug

What bug it is and which version of ICC is affected?

We found that

#include <stdio.h>
int main()
{
  #pragma omp parallel num_threads(2)
  #pragma omp master
    #pragma omp task
      #pragma omp task
        #pragma omp critical
          printf("test\n");
}

results in a segfault. icc 14-18 are affected. Paul Kapinos opened a ticket with Intel for this bug.
There is no segfault if the critical is in a function. Therefore we added the noinline for print_task_type.

[protze.joachim]

@omalyshe AFAIK this issue is Case#: 03138964

[protze.joachim]

LGTM

openmp/trunk/runtime/test/ompt/tasks/task_types.c

 // RUN: %libomp-compile-and-run | %sort-threads | FileCheck %s
 // REQUIRES: ompt
 #include "callback.h"
 #include <omp.h>
 #include <math.h>
 
-
+__attribute__ ((noinline)) // workaround for bug in icc
 void print_task_type(int id)
 {
   #pragma omp critical
   {
     int task_type;
     char buffer[2048];
     ompt_get_task_info(0, &task_type, NULL, NULL, NULL, NULL);
     format_task_type(task_type, buffer);

openmp/trunk/runtime/test/ompt/tasks/task_types_serialized.c

 // RUN: %libomp-compile-and-run | FileCheck %s
 // REQUIRES: ompt
 
 #include "callback.h"
 #include <omp.h>
 
+__attribute__ ((noinline)) // workaround for bug in icc
 void print_task_type(int id)
 {
   #pragma omp critical
   {
     int task_type;
     char buffer[2048];
     ompt_get_task_info(0, &task_type, NULL, NULL, NULL, NULL);
     format_task_type(task_type, buffer);