This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Improve wasm test cases
ClosedPublic

Authored by sbc100 on Dec 8 2017, 10:27 AM.

Details

Summary

Add test for weakly defined symbols with the same name

Improve test for call-indirect to include the same call in two different.
objects. This lays the ground work to improve the output via
de-duplicating the indirect call table: https://reviews.llvm.org/D40989

Also make all tests consistently pass -mtriple rather than
declaring in the sources.

Diff Detail

Repository
rL LLVM

Event Timeline

sbc100 created this revision.Dec 8 2017, 10:27 AM
sbc100 updated this revision to Diff 126179.Dec 8 2017, 10:31 AM
  • call indirect test
sbc100 retitled this revision from [WebAssembly] Add test for weakly defined symbols to [WebAssembly] Improve wasm test cases.Dec 8 2017, 10:34 AM
sbc100 edited the summary of this revision. (Show Details)
sbc100 added reviewers: ruiu, ncw.
This revision was automatically updated to reflect the committed changes.
ruiu edited edge metadata.Dec 8 2017, 11:26 AM

LGTM, but please submit this as two separate patches -- one for weak symbols and the other to fix -mtriple.

In D41024#949863, @ruiu wrote:

LGTM, but please submit this as two separate patches -- one for weak symbols and the other to fix -mtriple.

Sorry landed already. Will wait next time.