This is an archive of the discontinued LLVM Phabricator instance.

Differential D41019

NetBSD ships with POSIX strerror_r(3)
ClosedPublic

Authored by krytarowski on Dec 8 2017, 9:22 AM.

Details

Reviewers
joerg
eugenis
vitalybuka
Commits
rGfb2250459431: NetBSD ships with POSIX strerror_r(3)
rL320221: NetBSD ships with POSIX strerror_r(3)
rCRT320221: NetBSD ships with POSIX strerror_r(3)
Summary

Switch NetBSD from GNU to the POSIX strerror_r(3) interceptor.

Sponsored by <The NetBSD Foundation>

Diff Detail

Event Timeline

krytarowski created this revision.Dec 8 2017, 9:22 AM
Herald added subscribers: kubamracek, srhines. · View Herald TranscriptDec 8 2017, 9:22 AM
vitalybuka accepted this revision.Dec 8 2017, 3:50 PM
This revision is now accepted and ready to land.Dec 8 2017, 3:50 PM
Closed by commit rCRT320221: NetBSD ships with POSIX strerror_r(3) (authored by kamil). · Explain WhyDec 8 2017, 4:36 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
sanitizer_common/
2 lines

Diff 126235

lib/sanitizer_common/sanitizer_common_interceptors.inc

Show First 20 Lines • Show All 3,407 Lines • ▼ Show 20 Lines
#if SANITIZER_INTERCEPT_STRERROR_R #if SANITIZER_INTERCEPT_STRERROR_R
// There are 2 versions of strerror_r: // There are 2 versions of strerror_r:
// * POSIX version returns 0 on success, negative error code on failure, // * POSIX version returns 0 on success, negative error code on failure,
// writes message to buf. // writes message to buf.
// * GNU version returns message pointer, which points to either buf or some // * GNU version returns message pointer, which points to either buf or some
// static storage. // static storage.
#if ((_POSIX_C_SOURCE >= 200112L || _XOPEN_SOURCE >= 600) && !_GNU_SOURCE) || \ #if ((_POSIX_C_SOURCE >= 200112L || _XOPEN_SOURCE >= 600) && !_GNU_SOURCE) || \
SANITIZER_MAC || SANITIZER_ANDROID SANITIZER_MAC || SANITIZER_ANDROID || SANITIZER_NETBSD
// POSIX version. Spec is not clear on whether buf is NULL-terminated. // POSIX version. Spec is not clear on whether buf is NULL-terminated.
// At least on OSX, buf contents are valid even when the call fails. // At least on OSX, buf contents are valid even when the call fails.
INTERCEPTOR(int, strerror_r, int errnum, char *buf, SIZE_T buflen) { INTERCEPTOR(int, strerror_r, int errnum, char *buf, SIZE_T buflen) {
void *ctx; void *ctx;
COMMON_INTERCEPTOR_ENTER(ctx, strerror_r, errnum, buf, buflen); COMMON_INTERCEPTOR_ENTER(ctx, strerror_r, errnum, buf, buflen);
// FIXME: under ASan the call below may write to freed memory and corrupt // FIXME: under ASan the call below may write to freed memory and corrupt
// its metadata. See // its metadata. See
// https://github.com/google/sanitizers/issues/321. // https://github.com/google/sanitizers/issues/321.
▲ Show 20 Lines • Show All 3,106 Lines • Show Last 20 Lines