This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Make the new addr space mapping default
ClosedPublic

Authored by yaxunl on Dec 7 2017, 7:28 AM.

Diff Detail

Event Timeline

yaxunl created this revision.Dec 7 2017, 7:28 AM
arsenm added inline comments.Dec 11 2017, 2:37 PM
test/Analysis/CostModel/AMDGPU/addrspacecast.ll
1

That this is necessary is a bug. The specified triple should be sufficient

yaxunl updated this revision to Diff 127794.Dec 20 2017, 3:53 PM

Remove unnecessary datalayout from tests.

yaxunl added inline comments.Dec 20 2017, 6:16 PM
test/Analysis/CostModel/AMDGPU/addrspacecast.ll
1

Removed. Thanks.

yaxunl added inline comments.Jan 8 2018, 12:27 PM
test/Analysis/CostModel/AMDGPU/addrspacecast.ll
1

Fixed this issue in another patch https://reviews.llvm.org/D41832

Ping.

Since https://reviews.llvm.org/D41832 is not trivial and may take some time, I am wondering if we should not let it block this patch.

yaxunl updated this revision to Diff 132256.Jan 31 2018, 12:48 PM

Update tests. Removed redundant data layout.

arsenm accepted this revision.Jan 31 2018, 5:06 PM

LGTM

This revision is now accepted and ready to land.Jan 31 2018, 5:06 PM
This revision was automatically updated to reflect the committed changes.