This is an archive of the discontinued LLVM Phabricator instance.

Hardware-assisted AddressSanitizer (clang part).
ClosedPublic

Authored by eugenis on Dec 6 2017, 5:26 PM.

Diff Detail

Repository
rC Clang

Event Timeline

eugenis created this revision.Dec 6 2017, 5:26 PM
kcc accepted this revision.Dec 6 2017, 7:20 PM

LGTM
please give at least Aleksey a chance to review as well.

This revision is now accepted and ready to land.Dec 6 2017, 7:20 PM
alekseyshl accepted this revision.Dec 7 2017, 11:16 AM
alekseyshl added inline comments.
clang/include/clang/Basic/Sanitizers.def
47 ↗(On Diff #125858)

Why didn't we follow KASan style and name it "hw-address"?

clang/lib/Driver/SanitizerArgs.cpp
383 ↗(On Diff #125858)

Nit: 4 less spaces here and for the next pair.

eugenis added inline comments.Dec 7 2017, 11:34 AM
clang/include/clang/Basic/Sanitizers.def
47 ↗(On Diff #125858)

A matter of taste, I guess.
I don't want the attribute to be sanitize_hw_address, too many underscores.
Also, kernel is a word and hw is just to letters.

clang/lib/Driver/SanitizerArgs.cpp
383 ↗(On Diff #125858)
eugenis updated this revision to Diff 126060.Dec 7 2017, 3:20 PM

clang-format

This revision was automatically updated to reflect the committed changes.
This revision was automatically updated to reflect the committed changes.