This is an archive of the discontinued LLVM Phabricator instance.

[analyzer] Improve SymbolicRegion::dump() for heap pointers.
ClosedPublic

Authored by NoQ on Dec 4 2017, 10:33 AM.

Details

Summary

Because for every symbol $x we can construct exactly two different MemRegions that both get dumped as SymRegion{$x}, and i didn't bother fixing it for years, i wanted to at least make the problem apparent. With this patch, the unknown-memory-spaced symbolic region remains SymRegion{$x}, while the heap-based memory region is dumped as HeapSymRegion{$x}.

Does anybody want me to add tests for this debug print?

Diff Detail

Repository
rC Clang

Event Timeline

NoQ created this revision.Dec 4 2017, 10:33 AM
dcoughlin accepted this revision.Dec 4 2017, 7:39 PM

LGTM. Ship it!

This revision is now accepted and ready to land.Dec 4 2017, 7:39 PM
This revision was automatically updated to reflect the committed changes.