This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Split code-completion tests out of ClangdTests. NFC.
ClosedPublic

Authored by sammccall on Dec 4 2017, 6:34 AM.

Details

Summary

Common parts are mostly FS related, so pulled out TestFS.h for the common stuff.
Deliberately resisted cleaning up much here, so this is pretty mechanical.

Diff Detail

Repository
rL LLVM

Event Timeline

sammccall created this revision.Dec 4 2017, 6:34 AM
hokein accepted this revision.Dec 4 2017, 6:45 AM

LGTM.

unittests/clangd/CMakeLists.txt
16 ↗(On Diff #125329)

nit: maybe name it FSTests.cpp? to be consistent with other test file names.

This revision is now accepted and ready to land.Dec 4 2017, 6:45 AM
sammccall added inline comments.Dec 4 2017, 11:20 PM
unittests/clangd/CMakeLists.txt
16 ↗(On Diff #125329)

Ah, this is deliberately inconsistent, though :-)
This isn't a test file, it's a library that's used by tests.

This revision was automatically updated to reflect the committed changes.