Page MenuHomePhabricator

[libunwind] Switch to add_llvm_install_targets
ClosedPublic

Authored by smeenai on Nov 30 2017, 3:08 PM.

Event Timeline

smeenai created this revision.Nov 30 2017, 3:08 PM
beanz accepted this revision.Nov 30 2017, 3:12 PM

LGTM.

This revision is now accepted and ready to land.Nov 30 2017, 3:12 PM
This revision was automatically updated to reflect the committed changes.
dtzWill added a subscriber: dtzWill.Dec 8 2017, 6:43 AM

Hmm, this change means very recent LLVM is required to build libunwind-- previously I was able to use recent libunwind/libcxx/libcxxabi with LLVM 5 and LLVM 4.

Other runtime projects (compiler-rt, libcxx, libcxxabi) were modified to support the new "strip-and-install" targets such that they didn't depend on LLVM cmake bits, could that sort of approach work here?

The other runtime projects had the stripped installation targets added manually because they officially support being built completely standalone (i.e. without any LLVM components), so we can't rely on LLVM's CMake there. That's really unfortunate IMO, since it leads to a bunch of duplication, but it is what it is.

libunwind doesn't support building completely standalone AFAIK, so I think assuming trunk libunwind will be paired with trunk LLVM is pretty reasonable in general. It's easy enough to not break your use case here, however, so I went ahead and did so in r320163.

Okay, that makes sense. Thanks for accommodating my use-case anyway! :D.