Page MenuHomePhabricator

dtzWill (Will Dietz)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 16 2014, 9:28 AM (273 w, 5 d)

Recent Activity

Jan 11 2018

dtzWill added a comment to D28462: clang-format: Add new style option AlignConsecutiveMacros.

Ping! Is this stalling on reviewer attention? If so, please submit to LLVM Weekly's review corner (assuming it works with current LLVM), see http://llvmweekly.org/reviewcorner for details.

Jan 11 2018, 6:53 AM · Restricted Project, Restricted Project
Herald updated subscribers of D28462: clang-format: Add new style option AlignConsecutiveMacros.
Jan 11 2018, 6:43 AM · Restricted Project, Restricted Project

Dec 8 2017

dtzWill added a comment to D40685: [libunwind] Switch to add_llvm_install_targets.

Okay, that makes sense. Thanks for accommodating my use-case anyway! :D.

Dec 8 2017, 11:26 AM
dtzWill added a comment to D40685: [libunwind] Switch to add_llvm_install_targets.

Hmm, this change means very recent LLVM is required to build libunwind-- previously I was able to use recent libunwind/libcxx/libcxxabi with LLVM 5 and LLVM 4.

Dec 8 2017, 6:43 AM

Oct 19 2017

dtzWill added a comment to D38680: [libunwind] Fix handling of DW_CFA_GNU_args_size.

Wow, I've finally debugged some unwind failures to this on x86_64 Linux ...

  1. Call-frame optimization introduces it
  2. This fixes the cases I was investigating!!
Oct 19 2017, 6:29 PM

Jul 13 2017

dtzWill accepted D34121: [ubsan] Teach the pointer overflow check that "p - <unsigned> <= p" (PR33430).
Jul 13 2017, 11:41 AM
dtzWill added a comment to D34121: [ubsan] Teach the pointer overflow check that "p - <unsigned> <= p" (PR33430).
In D34121#806978, @vsk wrote:

@dtzWill do you have any further comments on this one?

I'd like to get another 'lgtm' before committing, and it'd be nice to get this in before llvm 5.0 branches (7/19).

FWIW we've been living on this for a few weeks internally without any issues:
https://github.com/apple/swift-clang/commit/3ebe7d87b9d545aebdd80452d0b79695ff871bce

Jul 13 2017, 11:40 AM

Jun 13 2017

dtzWill added a comment to D34121: [ubsan] Teach the pointer overflow check that "p - <unsigned> <= p" (PR33430).

Don't mean to block this, but just FYI I won't be able to look into this carefully until later this week (sorry!).

Jun 13 2017, 1:04 PM

Jun 12 2017

dtzWill accepted D33910: [ubsan] Detect invalid unsigned pointer index expression (clang).

Sorry for missing this originally, as a perhaps interesting note:
the checks were extracted from a research prototype that worked at the IR level --where pointer itself is unsigned but the offsets (including the computed total offset) is a signed expression[1].
(we also tracked conversions and whatnot, so... well things were different. Anyway, sorry for missing this!)

Jun 12 2017, 8:40 AM

May 29 2017

dtzWill accepted D33305: [ubsan] Add a check for pointer overflow UB.
May 29 2017, 10:44 AM
dtzWill added a comment to D33305: [ubsan] Add a check for pointer overflow UB.

I've built quite a bit with this (ground-up Linux distribution) which attests to it being fairly robust (no crashing or new errors not experienced with unpatched clang) and the bugs found so far are all true positives (few of which were caught and reported last time around).

May 29 2017, 10:43 AM

May 17 2017

dtzWill awarded D33305: [ubsan] Add a check for pointer overflow UB a Party Time token.
May 17 2017, 7:19 PM

May 9 2017

dtzWill added a comment to D20322: [ubsan] add pointer overflow checking.
In D20322#750381, @vsk wrote:

Hi @dtzWill, I have some time to work on this, and would be happy to implement the changes suggested by @rsmith. Let me know if it's all right for me to take a stab at this.

I"m not @dtzWill but I'm guessing he'll be happy for you to do this (same with me)!

May 9 2017, 6:31 PM

Feb 24 2017

dtzWill accepted D29369: [ubsan] Omit superflous overflow checks for promoted arithmetic (PR20193).

Sorry for the delay!

Feb 24 2017, 4:41 PM

Feb 14 2017

dtzWill added a comment to D29369: [ubsan] Omit superflous overflow checks for promoted arithmetic (PR20193).
In D29369#673064, @vsk wrote:

After some thought, can we discuss why this is a good idea?

The goal is to lower ubsan's compile-time + instrumentation overhead at -O0, since this reduces the friction of debugging a ubsan-instrumented project.

Feb 14 2017, 10:20 AM

Feb 9 2017

dtzWill requested changes to D29369: [ubsan] Omit superflous overflow checks for promoted arithmetic (PR20193).

After some thought, can we discuss why this is a good idea?

Feb 9 2017, 9:42 AM
dtzWill accepted D29369: [ubsan] Omit superflous overflow checks for promoted arithmetic (PR20193).

I've been bitten when attempting to use existence/nature of casts in the AST to reason about the original code, but this looks like it does the right thing in all the situations I can think of.

Feb 9 2017, 9:13 AM

Jan 28 2017

dtzWill added a comment to D28336: Replace addEarlyAsPossiblePasses callback with adjustPassManager.

Looks like this was fixed for NVPTX in r293256, Hexagon earlier. Can confirm resolves the issue I was encountering, thanks!

(And I think you're right, it only seems to have occurred in the shared library variants)

But now undefined reference in AMDGPU haha, but not relating to PassManagerBuilder :).

Thanks and sorry I did not notice it right away. For some reason my builds do work, just as Linux shared build I did right now. Do you still see error building AMDGPU or is it already fixed as well?

Jan 28 2017, 10:40 AM

Jan 27 2017

dtzWill added a comment to D28336: Replace addEarlyAsPossiblePasses callback with adjustPassManager.

Looks like this was fixed for NVPTX in r293256, Hexagon earlier. Can confirm resolves the issue I was encountering, thanks!

Jan 27 2017, 4:48 AM

Jan 26 2017

dtzWill added a comment to D28336: Replace addEarlyAsPossiblePasses callback with adjustPassManager.

Breaks build on other platforms too, for example: http://lab.llvm.org:8011/builders/clang-ppc64be-linux-multistage/builds/1928/steps/build%20stage%201/logs/stdio

Jan 26 2017, 6:15 PM

Jan 24 2017

dtzWill added a comment to rL292909: [lld][cmake] Fix BUILD_SHARED_LIBS installation.

Thanks for the fix!

Jan 24 2017, 12:32 PM

Jan 21 2017

dtzWill added a comment to D28397: [lld][cmake] Fix LLVM_LINK_LLVM_DYLIB build.

+1, I've been using trunk with this revision reverted since I need liblldELF as well. Would it fix all use cases if we added bits to install the libraries to add_lld_library?

Jan 21 2017, 12:17 PM

Sep 20 2016

dtzWill updated subscribers of D24682: [PR30341] Alias must point to a definition.
Sep 20 2016, 12:55 PM

Sep 15 2016

dtzWill updated subscribers of D24492: [LTO] Switch to the new resolution-based API..
Sep 15 2016, 9:29 AM

Aug 14 2016

dtzWill updated subscribers of D22370: Respect LLVM_HOST_TRIPLE when manually specified.
Aug 14 2016, 3:41 PM

Jun 22 2016

dtzWill updated subscribers of D19351: ELF: Add initial ThinLTO support..
Jun 22 2016, 1:29 PM

Jun 9 2016

dtzWill updated subscribers of D20272: [ELF] - Support of compressed input sections implemented..
Jun 9 2016, 12:59 PM

May 17 2016

dtzWill added inline comments to D20322: [ubsan] add pointer overflow checking.
May 17 2016, 2:21 PM
dtzWill added a comment to D20323: [ubsan] runtime support for pointer overflow checking.

Fixed test:

// RUN: %clangxx -fsanitize=pointer-overflow %s -o %t
// RUN: %t 1 2>&1 | FileCheck %s --check-prefix=ERR
// RUN: %t 0 2>&1 | FileCheck %s --check-prefix=SAFE
// RUN: %t -1 2>&1 | FileCheck %s --check-prefix=SAFE
May 17 2016, 11:48 AM
dtzWill added a comment to D20322: [ubsan] add pointer overflow checking.
May 17 2016, 11:46 AM
dtzWill added a comment to D20323: [ubsan] runtime support for pointer overflow checking.

Hmm, this test actually is wonky if argv[0] happens to be negative when represented as intptr_t... which happens on -m32 for my machine. I'll see about constructing a better test case!

May 17 2016, 10:24 AM