This is an archive of the discontinued LLVM Phabricator instance.

Differential D40681

[libc++abi] Add install-cxxabi-stripped target
ClosedPublic

Authored by smeenai on Nov 30 2017, 2:56 PM.

Details

Reviewers
beanz
compnerd
EricWF
Commits
rGacee992852fc: [libc++abi] Add install-cxxabi-stripped target
rCXXA319499: [libc++abi] Add install-cxxabi-stripped target
rL319499: [libc++abi] Add install-cxxabi-stripped target
Summary

LLVM is gaining install-*-stripped targets to perform stripped installs,
and in order for this to be useful for install-distribution, all
potential distribution components should have stripped installation
targets. LLVM has a function to create these install targets, but since
we can't use LLVM CMake functions in libc++abi, let's do it manually.

Diff Detail

Event Timeline

smeenai created this revision.Nov 30 2017, 2:56 PM
Herald added a subscriber: mgorny. · View Herald TranscriptNov 30 2017, 2:56 PM
Harbormaster completed remote builds in B12648: Diff 125035.Nov 30 2017, 2:56 PM
beanz accepted this revision.Nov 30 2017, 3:10 PM

LGTM.

This revision is now accepted and ready to land.Nov 30 2017, 3:10 PM
Closed by commit rL319499: [libc++abi] Add install-cxxabi-stripped target (authored by smeenai). · Explain WhyNov 30 2017, 3:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
src/
6 lines

Diff 125035

src/CMakeLists.txt

Show First 20 Lines • Show All 186 Lines • ▼ Show 20 Lines
endif() endif()
if (NOT CMAKE_CONFIGURATION_TYPES AND LIBCXXABI_INSTALL_LIBRARY) if (NOT CMAKE_CONFIGURATION_TYPES AND LIBCXXABI_INSTALL_LIBRARY)
add_custom_target(install-cxxabi add_custom_target(install-cxxabi
DEPENDS cxxabi DEPENDS cxxabi
COMMAND "${CMAKE_COMMAND}" COMMAND "${CMAKE_COMMAND}"
-DCMAKE_INSTALL_COMPONENT=cxxabi -DCMAKE_INSTALL_COMPONENT=cxxabi
-P "${LIBCXXABI_BINARY_DIR}/cmake_install.cmake") -P "${LIBCXXABI_BINARY_DIR}/cmake_install.cmake")
add_custom_target(install-cxxabi-stripped
DEPENDS cxxabi
COMMAND "${CMAKE_COMMAND}"
-DCMAKE_INSTALL_COMPONENT=cxxabi
-DCMAKE_INSTALL_DO_STRIP=1
-P "${LIBCXXABI_BINARY_DIR}/cmake_install.cmake")
# TODO: This is a legacy target name and should be removed at some point. # TODO: This is a legacy target name and should be removed at some point.
add_custom_target(install-libcxxabi DEPENDS install-cxxabi) add_custom_target(install-libcxxabi DEPENDS install-cxxabi)
endif() endif()