This is an archive of the discontinued LLVM Phabricator instance.

Flush gcda files before unlocking them
ClosedPublic

Authored by marco-c on Nov 29 2017, 9:15 AM.

Reviewers

Commits

Summary

I added two more reviewers as we would like to get that in trunk before 6.0 branches.

FYI, this was necessary to fix some intermittent issues for Firefox code coverage.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 3 2018, 3:14 AM

This revision was automatically updated to reflect the committed changes.

The change is very contained and safe and we need it in 6.0.

Path

Size

lib/

profile/

1 line

Show First 20 Lines • Show All 453 Lines • ▼ Show 20 Lines	if (output_file) {

if (new_file) {		if (new_file) {
fwrite(write_buffer, cur_pos, 1, output_file);		fwrite(write_buffer, cur_pos, 1, output_file);
free(write_buffer);		free(write_buffer);
} else {		} else {
unmap_file();		unmap_file();
}		}

		fflush(output_file);
lprofUnlockFd(fd);		lprofUnlockFd(fd);
fclose(output_file);		fclose(output_file);
output_file = NULL;		output_file = NULL;
write_buffer = NULL;		write_buffer = NULL;
}		}
free(filename);		free(filename);

#ifdef DEBUG_GCDAPROFILING		#ifdef DEBUG_GCDAPROFILING
▲ Show 20 Lines • Show All 86 Lines • Show Last 20 Lines