[clang-tidy] Correcting tests for ReplaceRandomShuffleCheck

[koldaniel]

Summary

Usage of the tag "CHECK-MESSAGES" in this test file is incorrect, since it is used as "CHECK-MESSAGE". This does not make the tests fail, but the check for correct warning messages will never happen.

[JonasToth]

Did you grep for that mistake on all test cases?

[aaron.ballman]

One small typo with one of the test changes, but otherwise LGTM, good catch!

test/clang-tidy/modernize-replace-random-shuffle.cpp

51

std::random_shuffle was correct; remove the extra 'd'.

[koldaniel]

In D40516#936563, @JonasToth wrote:

Did you grep for that mistake on all test cases?

Yes, I did, there were no other occurrences.

[JonasToth]

Ok. Very nice.

test/clang-tidy/modernize-replace-random-shuffle.cpp

 int myrandom (int i) { return i;}
 
 using namespace std;
 
 int main() {
   std::vector<int> vec;
 
   std::random_shuffle(vec.begin(), vec.end());
-  // CHECK-MESSAGE: [[@LINE-1]]:3: warning: 'std::random_shuffle' has been removed in C++17; use 'std::shuffle' instead
+  // CHECK-MESSAGES: [[@LINE-1]]:3: warning: 'std::random_shuffle' has been removed in C++17; use 'std::shuffle' instead
   // CHECK-FIXES: std::shuffle(vec.begin(), vec.end(), std::mt19937(std::random_device()()));
 
   std::shuffle(vec.begin(), vec.end());
 
   random_shuffle(vec.begin(), vec.end());
-  // CHECK-MESSAGE: [[@LINE-1]]:3: warning: 'std::random_shuffle' has been removed in C++17; use 'std::shuffle' instead
+  // CHECK-MESSAGES: [[@LINE-1]]:3: warning: 'std::random_shuffle' has been removed in C++17; use 'std::shuffle' instead
   // CHECK-FIXES: shuffle(vec.begin(), vec.end(), std::mt19937(std::random_device()()));
   
   std::random_shuffle(vec.begin(), vec.end(), myrandom);
-  // CHECK-MESSAGE: [[@LINE-1]]:3: warning: 'std::random_shuffle' has been removed in C++17; use 'std::shuffle' and an alternative random mechanism instead
+  // CHECK-MESSAGES: [[@LINE-1]]:3: warning: 'std::random_shuffle' has been removed in C++17; use 'std::shuffle' and an alternative random mechanism instead
   // CHECK-FIXES: std::shuffle(vec.begin(), vec.end(), std::mt19937(std::random_device()()));
 
   random_shuffle(vec.begin(), vec.end(), myrandom);
-  // CHECK-MESSAGE: [[@LINE-1]]:3: warning: 'std::random_shuffle' has been removed in C++17; use 'std::shuffle' and an alternative random mechanism instead
+  // CHECK-MESSAGES: [[@LINE-1]]:3: warning: 'stdd::random_shuffle' has been removed in C++17; use 'std::shuffle' and an alternative random mechanism instead
   // CHECK-FIXES: shuffle(vec.begin(), vec.end(), std::mt19937(std::random_device()()));
 
   shuffle(vec.begin(), vec.end());
 
   return 0;
 }