Page MenuHomePhabricator

[clang-tidy] Correcting tests for ReplaceRandomShuffleCheck
ClosedPublic

Authored by koldaniel on Nov 27 2017, 12:41 PM.

Details

Summary

Usage of the tag "CHECK-MESSAGES" in this test file is incorrect, since it is used as "CHECK-MESSAGE". This does not make the tests fail, but the check for correct warning messages will never happen.

Diff Detail

Event Timeline

koldaniel created this revision.Nov 27 2017, 12:41 PM
JonasToth added a project: Restricted Project.
JonasToth added a subscriber: JonasToth.

Did you grep for that mistake on all test cases?

aaron.ballman accepted this revision.Nov 27 2017, 12:52 PM

One small typo with one of the test changes, but otherwise LGTM, good catch!

test/clang-tidy/modernize-replace-random-shuffle.cpp
51

std::random_shuffle was correct; remove the extra 'd'.

This revision is now accepted and ready to land.Nov 27 2017, 12:52 PM
koldaniel added a comment.EditedNov 27 2017, 12:58 PM

Did you grep for that mistake on all test cases?

Yes, I did, there were no other occurrences.

Ok. Very nice.

This revision was automatically updated to reflect the committed changes.