Page MenuHomePhabricator

koldaniel (Daniel Kolozsvari)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 6 2017, 8:53 AM (93 w, 2 d)

Recent Activity

Tue, Mar 26

koldaniel created D59812: [analyzer] PR41185: Fix regression where __builtin_* functions weren't recognized.
Tue, Mar 26, 4:03 AM · Restricted Project, Restricted Project
koldaniel added a comment to D35068: [analyzer] Detect usages of unsafe I/O functions.

Bug fixing: faulty handling of built-in functions.

Please open a new differential, that is a completely new patch.

Tue, Mar 26, 4:03 AM · Restricted Project

Mon, Mar 25

koldaniel updated the diff for D35068: [analyzer] Detect usages of unsafe I/O functions.

Bug fixing: faulty handling of built-in functions.

Mon, Mar 25, 8:56 AM · Restricted Project

Sun, Mar 24

koldaniel added a comment to D35068: [analyzer] Detect usages of unsafe I/O functions.
In D35068#1438498, @NoQ wrote:

There seems to be a crash in this code. @koldaniel, would you like to take a look? https://bugs.llvm.org/show_bug.cgi?id=41185

Sun, Mar 24, 9:11 AM · Restricted Project

Mar 13 2019

koldaniel updated the diff for D33841: [clang-tidy] redundant keyword check.
Mar 13 2019, 12:32 AM · Restricted Project

Feb 9 2019

koldaniel updated the diff for D33841: [clang-tidy] redundant keyword check.

Rebased.

Feb 9 2019, 12:24 PM · Restricted Project
koldaniel updated the diff for D35068: [analyzer] Detect usages of unsafe I/O functions.

Rebased. Documentation added.

Feb 9 2019, 12:22 PM · Restricted Project
koldaniel added a comment to D35068: [analyzer] Detect usages of unsafe I/O functions.

Hmmm, DescFile was removed months ago from Checkers.td, are you sure you uploaded the correct diff?

Feb 9 2019, 9:03 AM · Restricted Project
koldaniel updated the diff for D35068: [analyzer] Detect usages of unsafe I/O functions.

Rebased.

Feb 9 2019, 8:12 AM · Restricted Project

Jan 29 2019

koldaniel updated the diff for D33841: [clang-tidy] redundant keyword check.

As it was mentioned earlier, I think it would be a better way forward to handle the check of redundant inlines in the scope of the other checker: https://reviews.llvm.org/D18914

Jan 29 2019, 9:40 AM · Restricted Project
koldaniel added inline comments to D33841: [clang-tidy] redundant keyword check.
Jan 29 2019, 9:34 AM · Restricted Project

Jul 3 2018

koldaniel added a comment to D35068: [analyzer] Detect usages of unsafe I/O functions.

Hi, could you please take a look at this issue?

Jul 3 2018, 3:54 AM · Restricted Project

Jun 7 2018

koldaniel commandeered D33841: [clang-tidy] redundant keyword check.
Jun 7 2018, 7:31 AM · Restricted Project

May 11 2018

koldaniel added a comment to D35068: [analyzer] Detect usages of unsafe I/O functions.

Do you have any other comments? Could this checker be delivered into security?

May 11 2018, 6:13 AM · Restricted Project
koldaniel added a comment to D33844: [clang-tidy] terminating continue check.

Which comments do you think are still relevant?

May 11 2018, 6:10 AM · Restricted Project

Apr 17 2018

koldaniel updated the diff for D33844: [clang-tidy] terminating continue check.
Apr 17 2018, 10:17 AM · Restricted Project
koldaniel added a comment to D35068: [analyzer] Detect usages of unsafe I/O functions.

@koldaniel Have you evaluated this checker? On which codebases? Were the warnings real security issues, or were they mostly spurious? The code seems fine, but I'm not sure whether it should be in security or in alpha.

Apr 17 2018, 8:35 AM · Restricted Project

Mar 27 2018

koldaniel updated the diff for D33844: [clang-tidy] terminating continue check.
Mar 27 2018, 10:11 AM · Restricted Project
koldaniel added a comment to D35068: [analyzer] Detect usages of unsafe I/O functions.

Do you have any other comments, or could this change be accepted?

Mar 27 2018, 9:07 AM · Restricted Project

Mar 22 2018

koldaniel added a comment to D33844: [clang-tidy] terminating continue check.

Please don't forget to add cfe-commits to Subscribers: when initially sending the patch for review. Otherwise nobody on the list will see it.

Could you run the check on LLVM+Clang and post a summary of your findings here?

Mar 22 2018, 7:51 AM · Restricted Project

Mar 12 2018

koldaniel commandeered D33844: [clang-tidy] terminating continue check.
Mar 12 2018, 8:34 AM · Restricted Project

Mar 6 2018

koldaniel updated the diff for D35068: [analyzer] Detect usages of unsafe I/O functions.
Mar 6 2018, 5:10 AM · Restricted Project

Mar 5 2018

koldaniel added inline comments to D35068: [analyzer] Detect usages of unsafe I/O functions.
Mar 5 2018, 5:25 AM · Restricted Project

Feb 28 2018

koldaniel updated the diff for D35068: [analyzer] Detect usages of unsafe I/O functions.
Feb 28 2018, 2:57 AM · Restricted Project

Feb 12 2018

koldaniel updated the diff for D40787: [clang-tidy] Replace the usage of std::uncaught_exception with std::uncaught_exceptions.
Feb 12 2018, 2:15 AM · Restricted Project

Feb 2 2018

koldaniel updated the diff for D40787: [clang-tidy] Replace the usage of std::uncaught_exception with std::uncaught_exceptions.
Feb 2 2018, 7:57 AM · Restricted Project

Jan 24 2018

koldaniel added inline comments to D40787: [clang-tidy] Replace the usage of std::uncaught_exception with std::uncaught_exceptions.
Jan 24 2018, 10:32 AM · Restricted Project

Jan 22 2018

koldaniel updated the diff for D40787: [clang-tidy] Replace the usage of std::uncaught_exception with std::uncaught_exceptions.
Jan 22 2018, 8:32 AM · Restricted Project

Jan 1 2018

koldaniel added inline comments to D40787: [clang-tidy] Replace the usage of std::uncaught_exception with std::uncaught_exceptions.
Jan 1 2018, 12:10 PM · Restricted Project
koldaniel added inline comments to D40787: [clang-tidy] Replace the usage of std::uncaught_exception with std::uncaught_exceptions.
Jan 1 2018, 10:53 AM · Restricted Project
koldaniel updated the diff for D40787: [clang-tidy] Replace the usage of std::uncaught_exception with std::uncaught_exceptions.
Jan 1 2018, 10:14 AM · Restricted Project

Dec 4 2017

koldaniel added inline comments to D40787: [clang-tidy] Replace the usage of std::uncaught_exception with std::uncaught_exceptions.
Dec 4 2017, 9:45 AM · Restricted Project
koldaniel created D40787: [clang-tidy] Replace the usage of std::uncaught_exception with std::uncaught_exceptions.
Dec 4 2017, 8:05 AM · Restricted Project

Nov 27 2017

koldaniel added a comment to D40516: [clang-tidy] Correcting tests for ReplaceRandomShuffleCheck.

Did you grep for that mistake on all test cases?

Nov 27 2017, 12:58 PM · Restricted Project
koldaniel updated the diff for D40516: [clang-tidy] Correcting tests for ReplaceRandomShuffleCheck.
Nov 27 2017, 12:55 PM · Restricted Project
koldaniel created D40516: [clang-tidy] Correcting tests for ReplaceRandomShuffleCheck.
Nov 27 2017, 12:41 PM · Restricted Project

Nov 16 2017

koldaniel added inline comments to D35068: [analyzer] Detect usages of unsafe I/O functions.
Nov 16 2017, 6:52 AM · Restricted Project

Nov 13 2017

koldaniel added inline comments to D35068: [analyzer] Detect usages of unsafe I/O functions.
Nov 13 2017, 9:30 AM · Restricted Project

Oct 5 2017

koldaniel updated the diff for D35068: [analyzer] Detect usages of unsafe I/O functions.
Oct 5 2017, 1:22 AM · Restricted Project

Aug 29 2017

koldaniel updated the diff for D35068: [analyzer] Detect usages of unsafe I/O functions.

Renaming the unsafe checker, updating tests.

Aug 29 2017, 8:00 AM · Restricted Project
koldaniel updated the diff for D35068: [analyzer] Detect usages of unsafe I/O functions.

Updated checker name, minor modifications

Aug 29 2017, 5:12 AM · Restricted Project
koldaniel added inline comments to D35068: [analyzer] Detect usages of unsafe I/O functions.
Aug 29 2017, 4:51 AM · Restricted Project

Jul 6 2017

koldaniel added a reviewer for D35068: [analyzer] Detect usages of unsafe I/O functions: zaks.anna.
Jul 6 2017, 9:55 AM · Restricted Project
koldaniel created D35068: [analyzer] Detect usages of unsafe I/O functions.
Jul 6 2017, 9:52 AM · Restricted Project