This is an archive of the discontinued LLVM Phabricator instance.

[APInt] Don't print debug messages from the APInt knuth division algorithm by default
ClosedPublic

Authored by craig.topper on Nov 23 2017, 3:00 PM.

Details

Summary

Debug builds currently print out low level details of the Knuth division algorithm when -debug is used. This information isn't useful in most cases and just adds noise to the log.

This adds a new preprocessor flag to enable the prints in the knuth division code in APInt.

Diff Detail

Event Timeline

craig.topper created this revision.Nov 23 2017, 3:00 PM
majnemer accepted this revision.Nov 23 2017, 9:55 PM
majnemer added a subscriber: majnemer.

LGTM, this had bugged me too.

This revision is now accepted and ready to land.Nov 23 2017, 9:55 PM
majnemer added inline comments.Nov 23 2017, 9:56 PM
lib/Support/APInt.cpp
1255–1259

*might* be nicer to use push_macro/pop_macro? Up to you in any case.

This revision was automatically updated to reflect the committed changes.