Page MenuHomePhabricator

[AMDGPU] SDWA: remove omod src operand for VOP2b instructions
ClosedPublic

Authored by SamWot on Nov 17 2017, 3:41 AM.

Details

Summary

VOP2b instructions (v_subbrev_u32, v_add_i32 ...) shouldn't support OMod operand in SDWA encoding

Diff Detail

Repository
rL LLVM

Event Timeline

SamWot created this revision.Nov 17 2017, 3:41 AM
dp accepted this revision.Nov 17 2017, 4:58 AM

Looks good

This revision is now accepted and ready to land.Nov 17 2017, 4:58 AM
rampitec accepted this revision.Nov 17 2017, 8:10 AM

Thank you!

SamWot updated this revision to Diff 123773.Nov 21 2017, 5:42 AM

Fix for VOP2b instructions was submitted in D40088.
Added SDWA dissassembler tests for VI.

This revision was automatically updated to reflect the committed changes.