This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Update test nullptr.ll to use amdgiz environment
ClosedPublic

Authored by yaxunl on Nov 15 2017, 7:55 PM.

Details

Summary

This test needs to be manually updated since it is difficult to do it with script.

Addr space 6 to 23 are only used by r600, therefore only check them for r600.

Diff Detail

Repository
rL LLVM

Event Timeline

yaxunl created this revision.Nov 15 2017, 7:55 PM
arsenm edited edge metadata.Nov 17 2017, 12:06 PM

Changing the size of the other address spaces seems like a problem, but I'm not sure what they are for. If we actually care about them, they need to be added to the datalayout

Changing the size of the other address spaces seems like a problem, but I'm not sure what they are for. If we actually care about them, they need to be added to the datalayout

It seems the backend uses these address spaces. I will update the datalayout instead.

Changing the size of the other address spaces seems like a problem, but I'm not sure what they are for. If we actually care about them, they need to be added to the datalayout

It seems the backend uses these address spaces. I will update the datalayout instead.

Actually addrspace 6 to 23 are only used by r600. I will add separate run line for amdgcn and r600.

yaxunl updated this revision to Diff 123952.Nov 22 2017, 8:21 AM
yaxunl edited the summary of this revision. (Show Details)

Add run line for r600.

arsenm accepted this revision.Nov 27 2017, 10:24 AM

LGTM

This revision is now accepted and ready to land.Nov 27 2017, 10:24 AM
This revision was automatically updated to reflect the committed changes.