This is an archive of the discontinued LLVM Phabricator instance.

[builtins][compiler-rt][ARM] re-enable test mulsc3
ClosedPublic

Authored by peter.smith on Nov 15 2017, 6:56 AM.

Details

Summary

The mulsc3_test.c is currently disabled with the comment citing PR32475. For me the test is passing for both Arm and Thumb, hard and soft float so I think we can re-enable it. The original cause of the failure should be fixed by D35538.

Note that PR number is slightly wrong as the 7 and 5 are transposed. The original bug should be https://bugs.llvm.org/show_bug.cgi?id=32457

Diff Detail

Repository
rL LLVM

Event Timeline

peter.smith created this revision.Nov 15 2017, 6:56 AM
efriedma accepted this revision.Nov 15 2017, 11:53 AM
efriedma added a subscriber: efriedma.

LGTM. (I haven't tested, but if it actually still isn't working, we want to know.)

This revision is now accepted and ready to land.Nov 15 2017, 11:53 AM
This revision was automatically updated to reflect the committed changes.

Thanks for the review. I've tested it locally; with luck it won't show up any problems in configurations I haven't covered. I'll revert and investigate if it causes any problem.