Also change some default cases into llvm_unreachable in WindowsResourceCOFFWriter, to make it easier to find if they are triggerd from within e.g. lld, which supported ARM64 earlier than llvm-cvtres did.
Details
Details
Diff Detail
Diff Detail
Event Timeline
Comment Actions
lgtm
lib/Object/WindowsResource.cpp | ||
---|---|---|
449 | I think we can sink this out, the switch is basically just a glorified assertion at this point. |
lib/Object/WindowsResource.cpp | ||
---|---|---|
449 | So just skip the whole switch and assert altogether and just make it all a plain Header->Machine = MachineType;? Sounds good to me. |
I think we can sink this out, the switch is basically just a glorified assertion at this point.