Page MenuHomePhabricator

[llvm-cvtres] Add support for ARM64
ClosedPublic

Authored by mstorsjo on Nov 10 2017, 1:59 AM.

Details

Summary

Also change some default cases into llvm_unreachable in WindowsResourceCOFFWriter, to make it easier to find if they are triggerd from within e.g. lld, which supported ARM64 earlier than llvm-cvtres did.

Diff Detail

Repository
rL LLVM

Event Timeline

mstorsjo created this revision.Nov 10 2017, 1:59 AM
ecbeckmann accepted this revision.Nov 10 2017, 12:47 PM
This revision is now accepted and ready to land.Nov 10 2017, 12:47 PM
rnk accepted this revision.Nov 10 2017, 1:18 PM

lgtm

lib/Object/WindowsResource.cpp
449 ↗(On Diff #122406)

I think we can sink this out, the switch is basically just a glorified assertion at this point.

mstorsjo added inline comments.Nov 10 2017, 1:34 PM
lib/Object/WindowsResource.cpp
449 ↗(On Diff #122406)

So just skip the whole switch and assert altogether and just make it all a plain Header->Machine = MachineType;? Sounds good to me.

This revision was automatically updated to reflect the committed changes.
ruiu edited edge metadata.Nov 13 2017, 1:46 AM

LGTM