This is an archive of the discontinued LLVM Phabricator instance.

[python] [tests] Fix test_linkage for unique external linkage
ClosedPublic

Authored by mgorny on Nov 8 2017, 10:49 AM.

Details

Summary

Starting with r314037, anonymous namespaces no longer give
unique-external linkage to variables. However, this linkage can still be
achieved by using a type which is not exterally visible,
e.g. through being declared in an anonymous namespace but used outside
it. Fix the test to take advantage of that.

Diff Detail

Event Timeline

mgorny created this revision.Nov 8 2017, 10:49 AM
mgorny abandoned this revision.Nov 8 2017, 11:13 AM

Duplicate of D39161.

mgorny updated this revision to Diff 122575.Nov 11 2017, 1:47 AM
mgorny retitled this revision from [clang] [python] [tests] Disable the broken unique-external linkage test to [python] [tests] Fix test_linkage for unique external linkage.
mgorny edited the summary of this revision. (Show Details)
mgorny added reviewers: jbcoe, aaron.ballman, frutiger.

Yay, I've found a way to get the desired linkage! ;-)

This revision is now accepted and ready to land.Nov 11 2017, 11:47 AM
This revision was automatically updated to reflect the committed changes.