This is an archive of the discontinued LLVM Phabricator instance.

[bindings] remove unique_external test failure
AbandonedPublic

Authored by frutiger on Oct 21 2017, 2:08 PM.

Details

Summary

In SVN r314037, linkage determination of a symbol was significantly
refactored. This resulted in extern anonymous namespace declarations to
no longer be considered 'unique_external'. This ultimately broke a test
in the Python bindings.

This commit removes the 'unique_external' test case.

Diff Detail

Event Timeline

frutiger created this revision.Oct 21 2017, 2:08 PM

I was unable to produce a simple test case that would still result in a cursor with 'unique external' linkage. @rsmith I would appreciate if you can think of a symbol that may still have this kind of linkage. Thanks!

mgorny added a subscriber: mgorny.

Let's try some more reviewers.

I've rewritten the tests to use unittest, so this patch needs to be updated now. However, you may want to wait a while since @compnerd promised to look at it and he might have a way to get uniqueExternal() linkage.

Thanks for the note, I'll wait.

frutiger abandoned this revision.Nov 11 2017, 12:14 PM

Fixed by r317986.