This is an archive of the discontinued LLVM Phabricator instance.

[analyzer] Document the issue hash debugging facility
ClosedPublic

Authored by xazax.hun on Nov 2 2017, 4:41 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

xazax.hun created this revision.Nov 2 2017, 4:41 AM
jklaehn added a subscriber: jklaehn.Nov 2 2017, 5:10 AM
jklaehn added inline comments.
docs/analyzer/DebugChecks.rst
247 ↗(On Diff #121275)

typo reports?

NoQ edited edge metadata.Nov 2 2017, 5:16 AM

Yup, thanks!

docs/analyzer/DebugChecks.rst
255 ↗(On Diff #121275)

Unlike printState and like all other functions, your function doesn't dump to plain stderr, but generates warnings instead. I didn't want printState to produce huge warnings because matching them with expected-warning would be more disgusting than FileChecking, but that's not your case. So i think you'd like to document it similarly to other functions, probably as // expected-warning{{'sample output'}}.

xazax.hun updated this revision to Diff 121290.Nov 2 2017, 6:05 AM
xazax.hun marked 2 inline comments as done.
xazax.hun added inline comments.
docs/analyzer/DebugChecks.rst
255 ↗(On Diff #121275)

Yeah, sorry for the oversight. :) I wanted to get the documentation part done as soon as possible to work on other parts. But it looks like these kinds of tasks should have the same level of attention as others.

NoQ accepted this revision.Nov 9 2017, 11:41 PM

these kinds of tasks should have the same level of attention as others

Dunno really. I'm not sure anybody actually reads that doc instead of accidentally finding the checker code by debugging how the tests work.

This revision is now accepted and ready to land.Nov 9 2017, 11:41 PM
This revision was automatically updated to reflect the committed changes.