Page MenuHomePhabricator

jklaehn (Johann Klähn)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 9 2017, 2:40 AM (114 w, 12 h)

Recent Activity

Jan 9 2019

jklaehn added inline comments to D56244: [XRay][docs] XRay Framework Usage Guide.
Jan 9 2019, 12:38 PM

Apr 15 2018

jklaehn updated the diff for D35181: Defer addition of keywords to identifier table when loading AST.

Thanks for the review! As I do not have commit access, it would be great if you could commit the updated patch.

Apr 15 2018, 10:39 AM · Restricted Project

Apr 14 2018

jklaehn added a comment to D35181: Defer addition of keywords to identifier table when loading AST.

friendly ping? :)

Apr 14 2018, 6:51 AM · Restricted Project

Apr 4 2018

jklaehn updated the diff for D35181: Defer addition of keywords to identifier table when loading AST.

ping? (rebased)

Apr 4 2018, 1:23 PM · Restricted Project

Dec 20 2017

jklaehn updated the diff for D35181: Defer addition of keywords to identifier table when loading AST.

ping (rebased)

Dec 20 2017, 4:54 AM · Restricted Project

Dec 14 2017

jklaehn added a comment to D36952: [libclang] Add support for checking abstractness of records.

Thanks! However, compared to diff 126298 (https://reviews.llvm.org/differential/diff/126298/), there seems to be duplication in the committed change (maybe some artifacts due to rebasing/merging?). Should I submit a follow-up patch to fix this?

Dec 14 2017, 2:48 PM · Restricted Project

Dec 12 2017

jklaehn added a comment to D36952: [libclang] Add support for checking abstractness of records.

LGTM

Dec 12 2017, 5:47 AM · Restricted Project

Dec 10 2017

jklaehn updated the diff for D36952: [libclang] Add support for checking abstractness of records.

ping (rebased)

Dec 10 2017, 12:15 PM · Restricted Project
jklaehn added a comment to D35181: Defer addition of keywords to identifier table when loading AST.

LGTM, but I'd like the old IdentifierTable constructor to be removed if there are no callers left.

Dec 10 2017, 10:02 AM · Restricted Project

Dec 7 2017

jklaehn added a comment to D35181: Defer addition of keywords to identifier table when loading AST.

Ping, can you take another look?

Dec 7 2017, 1:55 PM · Restricted Project

Nov 19 2017

jklaehn updated the diff for D35181: Defer addition of keywords to identifier table when loading AST.

Thanks for taking a look! I removed the constructor argument as suggested; keywords are now added in PP.Initialize.

Nov 19 2017, 4:58 AM · Restricted Project

Nov 2 2017

jklaehn added inline comments to D39543: [analyzer] Document the issue hash debugging facility.
Nov 2 2017, 5:10 AM
jklaehn added a comment to D39332: [clang-refactor] Introduce a new rename rule for qualified symbols.

I spotted two typos. :) Also, the commit message needs to be updated.

Nov 2 2017, 2:17 AM

Oct 25 2017

jklaehn added inline comments to D39217: [libclang, bindings]: add spelling location.
Oct 25 2017, 1:54 AM

Oct 24 2017

jklaehn added a comment to D35181: Defer addition of keywords to identifier table when loading AST.

ping :)

Oct 24 2017, 1:50 PM · Restricted Project
jklaehn added a comment to D36952: [libclang] Add support for checking abstractness of records.

ping :)

Oct 24 2017, 1:50 PM · Restricted Project
jklaehn added inline comments to D39217: [libclang, bindings]: add spelling location.
Oct 24 2017, 1:40 PM

Oct 14 2017

jklaehn added inline comments to D37905: [libclang, bindings]: add spelling location.
Oct 14 2017, 1:53 PM

Oct 11 2017

jklaehn added a comment to D36955: [libclang] Visit attributes for function and class templates.

LGTM

Would you like me to commit this for you?

Oct 11 2017, 1:06 AM · Restricted Project
jklaehn added a comment to D36973: [libclang] Add support for querying cursor availability.

LGTM

Would you like me to commit this for you?

Oct 11 2017, 1:05 AM · Restricted Project

Oct 10 2017

jklaehn updated the diff for D36973: [libclang] Add support for querying cursor availability.

Use user-defined function for test of AvailabilityKind.DEPRECATED.

Oct 10 2017, 2:15 AM · Restricted Project
jklaehn updated the diff for D36955: [libclang] Visit attributes for function and class templates.

Added c-index-test-based test.

Oct 10 2017, 2:13 AM · Restricted Project

Sep 25 2017

jklaehn added a reviewer for D36955: [libclang] Visit attributes for function and class templates: jbcoe.

ping :)

Sep 25 2017, 5:02 AM · Restricted Project
jklaehn updated the diff for D36973: [libclang] Add support for querying cursor availability.

Added test for AvailabilityKind.DEPRECATED. NOT_ACCESSIBLE is never returned by clang_getCursorAvailability but only only used in CodeCompletionResult.

Sep 25 2017, 5:02 AM · Restricted Project

Sep 21 2017

jklaehn added a comment to D36953: [libclang] Keep track of TranslationUnit instance when annotating tokens.

Do you need someone to commit this change for you?

I'm happy to do so if you don't have commit access.

Sep 21 2017, 3:33 AM · Restricted Project

Sep 2 2017

jklaehn added inline comments to D33825: [clang-tidy] signal handler must be plain old function check.
Sep 2 2017, 9:48 AM · Restricted Project

Aug 25 2017

jklaehn added a comment to D35271: Fix printing policy for AST context loaded from file.
In D35271#850472, @vsk wrote:

Thanks, LGTM! This seems like a pretty straightforward bug fix. Since it's not my usual area maybe it'd be worth waiting a day or so for more feedback.

Aug 25 2017, 12:22 AM · Restricted Project

Aug 23 2017

jklaehn updated the diff for D35271: Fix printing policy for AST context loaded from file.

Update regression test to use createTemporaryFile() and tool_output_file as suggested.

Aug 23 2017, 5:12 AM · Restricted Project

Aug 22 2017

jklaehn updated the diff for D35271: Fix printing policy for AST context loaded from file.

Added regression test.

Aug 22 2017, 3:40 AM · Restricted Project

Aug 21 2017

jklaehn created D36973: [libclang] Add support for querying cursor availability.
Aug 21 2017, 11:41 AM · Restricted Project
jklaehn created D36955: [libclang] Visit attributes for function and class templates.
Aug 21 2017, 6:21 AM · Restricted Project
jklaehn created D36953: [libclang] Keep track of TranslationUnit instance when annotating tokens.
Aug 21 2017, 5:26 AM · Restricted Project
jklaehn created D36952: [libclang] Add support for checking abstractness of records.
Aug 21 2017, 5:20 AM · Restricted Project
jklaehn added a comment to D35271: Fix printing policy for AST context loaded from file.
In D35271#809159, @vsk wrote:

I wonder if it's possible to do away with the calls to 'updated()'... it seems strange that we initialize the same preprocessor repeatedly. Is there any way to finalize an ASTInfoCollector after ReadAST happens (or ASTReaderListeners in general)?

Aug 21 2017, 5:08 AM · Restricted Project

Jul 11 2017

jklaehn created D35271: Fix printing policy for AST context loaded from file.
Jul 11 2017, 11:22 AM · Restricted Project
jklaehn added a comment to D35187: [libclang] Support for querying whether an enum is scoped.

I do not have commit access, it would be great if you could commit it. Thanks!

Jul 11 2017, 11:06 AM · Restricted Project
jklaehn updated the diff for D35187: [libclang] Support for querying whether an enum is scoped.
Jul 11 2017, 10:41 AM · Restricted Project

Jul 9 2017

jklaehn created D35187: [libclang] Support for querying whether an enum is scoped.
Jul 9 2017, 2:56 PM · Restricted Project
jklaehn created D35181: Defer addition of keywords to identifier table when loading AST.
Jul 9 2017, 9:10 AM · Restricted Project