This is an archive of the discontinued LLVM Phabricator instance.

Differential D39522

[clang-rename] Use add_clang_tool
ClosedPublic

Authored by smeenai on Nov 1 2017, 5:43 PM.

Details

Reviewers
arphaman
beanz
compnerd
Commits
rG30e182d45406: [clang-rename] Use add_clang_tool
rC317150: [clang-rename] Use add_clang_tool
rL317150: [clang-rename] Use add_clang_tool
Summary

add_clang_tool includes a call to add_clang_executable, but it also
sets up the install rule, and adds an install-* target. The latter is
required for using LLVM_DISTRIBUTION_COMPONENTS.

Diff Detail

Event Timeline

smeenai created this revision.Nov 1 2017, 5:43 PM
Harbormaster completed remote builds in B11735: Diff 121216.Nov 1 2017, 5:43 PM
Herald added a subscriber: mgorny. · View Herald TranscriptNov 1 2017, 5:43 PM
arphaman accepted this revision.Nov 1 2017, 5:55 PM

LGTM.

This revision is now accepted and ready to land.Nov 1 2017, 5:55 PM
Closed by commit rL317150: [clang-rename] Use add_clang_tool (authored by smeenai). · Explain WhyNov 1 2017, 6:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
tools/
clang-rename/
4 lines

Diff 121216

tools/clang-rename/CMakeLists.txt

set(LLVM_LINK_COMPONENTS set(LLVM_LINK_COMPONENTS
Option Option
Support Support
) )
add_clang_executable(clang-rename ClangRename.cpp) add_clang_tool(clang-rename ClangRename.cpp)
target_link_libraries(clang-rename target_link_libraries(clang-rename
clangBasic clangBasic
clangFrontend clangFrontend
clangRewrite clangRewrite
clangTooling clangTooling
clangToolingCore clangToolingCore
clangToolingRefactor clangToolingRefactor
) )
install(TARGETS clang-rename RUNTIME DESTINATION bin)
install(PROGRAMS clang-rename.py install(PROGRAMS clang-rename.py
DESTINATION share/clang DESTINATION share/clang
COMPONENT clang-rename) COMPONENT clang-rename)
install(PROGRAMS clang-rename.el install(PROGRAMS clang-rename.el
DESTINATION share/clang DESTINATION share/clang
COMPONENT clang-rename) COMPONENT clang-rename)