Add read and write functions for VSX, VMX and float registers and fix watchpoint size
Details
Details
Diff Detail
Diff Detail
- Build Status
Buildable 11809 Build 11809: arc lint + arc unit
Event Timeline
source/Plugins/Process/Linux/NativeRegisterContextLinux_ppc64le.cpp | ||
---|---|---|
534 | Isn't this somewhat over-engineered? I mean, GetVMXBuffer returns a pointer to a member variable, so it's pretty much impossible for it to be null. And all GetVMXSize does is return the size of that member variable. If we remove all this boilerplate then this becomes something like: int regset = NT_PPC_VMX; return NativeProcessLinux::PtraceWrapper(PTRACE_SETVRREGS, m_thread.GetID(), ®set, &m_vmx_ppc64le, sizeof(m_vmx_ppc64le)); which I think is much easier to follow than jumping through dozens of these tiny functions |
Isn't this somewhat over-engineered?
I mean, GetVMXBuffer returns a pointer to a member variable, so it's pretty much impossible for it to be null. And all GetVMXSize does is return the size of that member variable. If we remove all this boilerplate then this becomes something like:
which I think is much easier to follow than jumping through dozens of these tiny functions