Page MenuHomePhabricator

[dsymutil] Timestmap verification for __swift_ast
ClosedPublic

Authored by JDevlieghere on Oct 9 2017, 4:41 AM.

Details

Summary

This patch adds timestamp verification for swiftmodule files.

  • A new flag is provided to allows us to continue testing of the code for embedding the__swift_ast. (git doesn't maintain timestamps)
  • Adds a new test for fat (arm) binaries.

Diff Detail

Repository
rL LLVM

Event Timeline

JDevlieghere created this revision.Oct 9 2017, 4:41 AM
fjricci accepted this revision.Oct 9 2017, 7:41 AM

Looks good to me

This revision is now accepted and ready to land.Oct 9 2017, 7:41 AM
  • Format changes
aprantl added inline comments.Oct 9 2017, 3:41 PM
test/tools/dsymutil/ARM/swift-ast.test
1 ↗(On Diff #118246)

if the test is disabling the new functionality (-no-swiftmodule-timestamp) what is it testing?

JDevlieghere added inline comments.Oct 9 2017, 4:33 PM
test/tools/dsymutil/ARM/swift-ast.test
1 ↗(On Diff #118246)

I used this to verify my implementation locally, and figured I might as well upstream it as it covers two scenarios (arm & universal mach-o) not covered by the existing test. Let me know if you would leave this out or have it moved into in a separate commit.

aprantl added inline comments.Oct 9 2017, 4:35 PM
test/tools/dsymutil/ARM/swift-ast.test
1 ↗(On Diff #118246)

the extra test is fine, I was just wondering if the test shouldn't be testing for the "Timestamp mismatch" warning.

JDevlieghere set the repository for this revision to rL LLVM.
  • Update tests to check for warnings
aprantl accepted this revision.Oct 10 2017, 7:38 AM
This revision was automatically updated to reflect the committed changes.