Page MenuHomePhabricator

[ARM/AARCH64] Make test MachineBranchProb.ll more robust and re-enable for ARM/AArch64
ClosedPublic

Authored by bmakam on Oct 5 2017, 10:58 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

bmakam created this revision.Oct 5 2017, 10:58 AM
fhahn accepted this revision.Oct 5 2017, 11:05 AM
fhahn added a subscriber: fhahn.

LGTM. Enabling the test on ARM/AArch64 is a definite improvement IMO. Just a nit about the placement of the declare

test/CodeGen/Generic/MachineBranchProb.ll
11 ↗(On Diff #117851)

Maybe move this declare above the comment, with an extra blank line?

This revision is now accepted and ready to land.Oct 5 2017, 11:05 AM
fhahn added inline comments.Oct 5 2017, 11:06 AM
test/CodeGen/Generic/MachineBranchProb.ll
30 ↗(On Diff #117851)

Maybe also add a comment that this is here to prevent the SimplifyCFG pass run on AArch64/ARM to mess things up

This revision was automatically updated to reflect the committed changes.

I modified the test case per your suggestions before commiting. Thanks for taking a look.