Page MenuHomePhabricator

update comments in clang-format.py for python3 compatibility
AcceptedPublic

Authored by pseyfert on Oct 1 2017, 5:37 AM.

Details

Summary

D23319 introduced python3 compatibility to clang-format.py, this is however not reflected by the documentation in the comments at the beginning of the file, which show how to use the script with python2 in .vimrc. While the actual mapping a user might want to use may well differ from my suggestion, I think it's nice to show the python2 and python3 version, such that a user can pick from the suggestions instead of googeling the python3 replacement for :pyf which they might not be familiar with.

EDIT: picking reviewers according to https://llvm.org/docs/Phabricator.html#finding-potential-reviewers

Diff Detail

Repository
rL LLVM

Event Timeline

pseyfert created this revision.Oct 1 2017, 5:37 AM
ychen added a subscriber: ychen.Jun 28 2019, 2:24 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 28 2019, 2:24 PM
pseyfert changed the repository for this revision from rL LLVM to rC Clang.
Herald added a project: Restricted Project. · View Herald TranscriptSep 17 2019, 7:08 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
pseyfert edited the summary of this revision. (Show Details)Sep 20 2019, 8:34 AM
pseyfert added reviewers: ilya-biryukov, klimek.
ilya-biryukov added a subscriber: ilya-biryukov.

@MyDeveloperDay, added you on the assumption that you are interested in all things about clang-format. Hope the change is relevant, let me know if not.

MyDeveloperDay accepted this revision.Sep 23 2019, 12:28 PM

I'm not python expert but as this is a comment I don't see any issue. LGTM

This revision is now accepted and ready to land.Sep 23 2019, 12:28 PM