This is an archive of the discontinued LLVM Phabricator instance.

Update ABISysV_arm64::RegisterIsVolatile to accept registers prefixed with r
ClosedPublic

Authored by xiaobai on Sep 28 2017, 12:07 PM.

Details

Summary

While the specification says that the 64bit registers are prefixed with
x, it seems that many people still use r. Until recently, we had been using
the r prefix instead of the x prefix in ds2. This caused lldb to fail during
unwinding. I think it's reasonable to check for a register prefixed with r,
since some people still choose to use r.

Event Timeline

xiaobai created this revision.Sep 28 2017, 12:07 PM
sas accepted this revision.Sep 28 2017, 12:35 PM

Looks good to me, but I'd like to see what @clayborg thinks about this.

This revision is now accepted and ready to land.Sep 28 2017, 12:35 PM

@clayborg: Any objection to this?

clayborg accepted this revision.Oct 9 2017, 8:00 AM

Back from vacation, sorry for the delay.

This revision was automatically updated to reflect the committed changes.