[X86][MC] Fixed crash when assembling a file that contains section with 64-bit alignment (PR34726)
Needs ReviewPublic
Actions

Authored by kbelochapka on Sep 26 2017, 6:49 PM.

Details

Reviewers

craig.topper
• espindola

Summary

Allow section alignment value to be 64 bit.

Diff Detail

Event Timeline

kbelochapka created this revision.Sep 26 2017, 6:49 PM

Herald added subscribers: aheejin, sbc100, sdardis, emaste. · View Herald TranscriptSep 26 2017, 6:49 PM

craig.topper added a reviewer: • rafael.Sep 26 2017, 11:43 PM

@rafael this looks pretty benign to me, but MC is not my area. What do you think?

include/llvm/MC/MCFragment.h
296	Please reorder the fields so that the three 64-bit members are next to each other. This will reduce the space wasted for padding.

• espindola edited reviewers, added: • espindola; removed: • rafael.Mar 15 2018, 9:10 AM

Herald added a subscriber: arichardson. · View Herald TranscriptMar 15 2018, 9:10 AM

Revision Contents
Changeset List

Path

Size

include/

llvm/

MC/

10 lines

16 lines

8 lines

6 lines

16 lines

10 lines

8 lines

lib/

MC/

4 lines

32 lines

13 lines

16 lines

4 lines

11 lines

12 lines

12 lines

MCWinCOFFStreamer.cpp

8 lines

WasmObjectWriter.cpp

8 lines

Object/

RecordStreamer.h

4 lines

RecordStreamer.cpp

4 lines

Target/

Mips/

MCTargetDesc/

MipsTargetStreamer.cpp

6 lines

test/

MC/

ELF/

align-64-bits.s

39 lines

align-nops-64-bits.s

24 lines

Diff 116746

View Options

include/llvm/MC/MCELFStreamer.h

View Options

include/llvm/MC/MCFragment.h

View Options

include/llvm/MC/MCObjectStreamer.h

View Options

include/llvm/MC/MCSection.h

View Options

include/llvm/MC/MCStreamer.h

View Options

include/llvm/MC/MCWasmStreamer.h

View Options

include/llvm/MC/MCWinCOFFStreamer.h

View Options

lib/MC/ELFObjectWriter.cpp

View Options

lib/MC/MCAsmStreamer.cpp

View Options

lib/MC/MCELFStreamer.cpp

View Options

lib/MC/MCMachOStreamer.cpp

View Options

lib/MC/MCNullStreamer.cpp

View Options

lib/MC/MCObjectStreamer.cpp

View Options

lib/MC/MCStreamer.cpp

View Options

lib/MC/MCWasmStreamer.cpp

View Options

lib/MC/MCWinCOFFStreamer.cpp

View Options

lib/MC/WasmObjectWriter.cpp

View Options

lib/Object/RecordStreamer.h

View Options

lib/Object/RecordStreamer.cpp

View Options

lib/Target/Mips/MCTargetDesc/MipsTargetStreamer.cpp

View Options

test/MC/ELF/align-64-bits.s

View Options

test/MC/ELF/align-nops-64-bits.s

[X86][MC] Fixed crash when assembling a file that contains section with 64-bit alignment (PR34726)Needs ReviewPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 116746

include/llvm/MC/MCELFStreamer.h

include/llvm/MC/MCFragment.h

include/llvm/MC/MCObjectStreamer.h

include/llvm/MC/MCSection.h

include/llvm/MC/MCStreamer.h

include/llvm/MC/MCWasmStreamer.h

include/llvm/MC/MCWinCOFFStreamer.h

lib/MC/ELFObjectWriter.cpp

lib/MC/MCAsmStreamer.cpp

lib/MC/MCELFStreamer.cpp

lib/MC/MCMachOStreamer.cpp

lib/MC/MCNullStreamer.cpp

lib/MC/MCObjectStreamer.cpp

lib/MC/MCStreamer.cpp

lib/MC/MCWasmStreamer.cpp

lib/MC/MCWinCOFFStreamer.cpp

lib/MC/WasmObjectWriter.cpp

lib/Object/RecordStreamer.h

lib/Object/RecordStreamer.cpp

lib/Target/Mips/MCTargetDesc/MipsTargetStreamer.cpp

test/MC/ELF/align-64-bits.s

test/MC/ELF/align-nops-64-bits.s

[X86][MC] Fixed crash when assembling a file that contains section with 64-bit alignment (PR34726)
Needs ReviewPublic
Actions

Revision Contents
Changeset List