Previouly these were being included as both imports and
exports, with the import being satisfied by the export
(or some strong symbol) at runtime. However this proved
unnecesary and actually complicated linking as it meant
there was not a 1-to-1 mapping between a wasm function
/global index and a linker symbol.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
lib/Object/WasmObjectFile.cpp | ||
---|---|---|
340 ↗ | (On Diff #116586) | I just remembered that try_emplace is a C++17 function, so it may not be in the stdlib on all supported LLVM platforms; we should probably switch to something else. |
Comment Actions
That can be a separate change though.
Is this in tool-conventions yet? If so, should update.
lib/Object/WasmObjectFile.cpp | ||
---|---|---|
340 ↗ | (On Diff #116586) | Its been in here for months now.. so at least there are not bots that can't build this. Oh I see, this is a StringMap which does define its own try_emplace() method.. so we should be fine. |