This is an archive of the discontinued LLVM Phabricator instance.

[sanitizer_common] Don't provide sanitizer_procmaps API functions where not defined
ClosedPublic

Authored by fjricci on Sep 22 2017, 2:05 PM.

Details

Summary

Platforms that don't implement procmaps (primarily fuchsia and windows) still expose
the procmaps API when including sanitizer_procmaps.h, despite not implementing the functions
provided by that header. Ensure that the API is only exposed on platforms that implement it.

Event Timeline

fjricci created this revision.Sep 22 2017, 2:05 PM

I tested that this builds on mac, linux, android, and windows, but I don't have a fuschia cross-compilation toolchain set up to test there. Should be more or less the same as windows though.

vitalybuka accepted this revision.Sep 25 2017, 12:41 PM
This revision is now accepted and ready to land.Sep 25 2017, 12:41 PM
This revision was automatically updated to reflect the committed changes.